Skip to content

Skip ro segments which are not in range when walking heap for GC diagnostics #100002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Skip ro segments which are not in range when walking heap for GC diagnostics #100002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/coreclr/gc/gc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52095,7 +52095,7 @@ void CFinalize::CheckFinalizerObjects()
void gc_heap::walk_heap_per_heap (walk_fn fn, void* context, int gen_number, BOOL walk_large_object_heap_p)
{
generation* gen = gc_heap::generation_of (gen_number);
heap_segment* seg = generation_start_segment (gen);
heap_segment* seg = heap_segment_in_range (generation_start_segment (gen));
uint8_t* x = ((gen_number == max_generation) ? heap_segment_mem (seg) : get_soh_start_object (seg, gen));
uint8_t* end = heap_segment_allocated (seg);
int align_const = get_alignment_constant (TRUE);
Expand All @@ -52105,7 +52105,7 @@ void gc_heap::walk_heap_per_heap (walk_fn fn, void* context, int gen_number, BOO
{
if (x >= end)
{
if ((seg = heap_segment_next (seg)) != 0)
if ((seg = heap_segment_next_in_range (seg)) != 0)
{
x = heap_segment_mem (seg);
end = heap_segment_allocated (seg);
Expand All @@ -52117,7 +52117,7 @@ void gc_heap::walk_heap_per_heap (walk_fn fn, void* context, int gen_number, BOO
// advance to next lower generation
gen_number--;
gen = gc_heap::generation_of (gen_number);
seg = generation_start_segment (gen);
seg = heap_segment_in_range (generation_start_segment (gen));

x = heap_segment_mem (seg);
end = heap_segment_allocated (seg);
Expand All @@ -52129,12 +52129,12 @@ void gc_heap::walk_heap_per_heap (walk_fn fn, void* context, int gen_number, BOO
if (walk_large_object_heap_p)
{
walk_large_object_heap_p = FALSE;
seg = generation_start_segment (large_object_generation);
seg = heap_segment_in_range (generation_start_segment (large_object_generation));
}
else if (walk_pinned_object_heap)
{
walk_pinned_object_heap = FALSE;
seg = generation_start_segment (pinned_object_generation);
seg = heap_segment_in_range (generation_start_segment (pinned_object_generation));
}
else
{
Expand Down