Transitive KeydService

[pengweiqhca]

Description

Injecting into a keyed service should prioritize keyed service.

Reproduction Steps

var services = new ServiceCollection();

services.AddSingleton(_ => new A("Default"))
    .AddKeyedSingleton(KeyedService.AnyKey, (_, _) => new A("AnyKey"))
    .AddKeyedSingleton("Keyed", (_, _) => new A("Keyed"))
    .AddSingleton<B>().AddKeyedSingleton<B>(KeyedService.AnyKey);

var provider = services.BuildServiceProvider();

provider.GetRequiredService<B>().A.Write();
provider.GetRequiredKeyedService<B>("Keyed").A.Write();
provider.GetRequiredKeyedService<B>(new()).A.Write();

class A(object a)
{
    public void Write() => Console.WriteLine(a);
}

class B(A a)
{
    public A A { get; } = a;
}

Expected behavior

Default
Keyed
AnyKey

Actual behavior

Default
Default
Default

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Injecting into a keyed service should prioritize keyed service.

Reproduction Steps

var services = new ServiceCollection();

services.AddSingleton(_ => new A("Default"))
    .AddKeyedSingleton(KeyedService.AnyKey, (_, _) => new A("AnyKey"))
    .AddKeyedSingleton("Keyed", (_, _) => new A("Keyed"))
    .AddSingleton<B>().AddKeyedSingleton<B>(KeyedService.AnyKey);

var provider = services.BuildServiceProvider();

provider.GetRequiredService<B>().A.Write();
provider.GetRequiredKeyedService<B>("Keyed").A.Write();
provider.GetRequiredKeyedService<B>(new()).A.Write();

class A(object a)
{
    public void Write() => Console.WriteLine(a);
}

class B(A a)
{
    public A A { get; } = a;
}

Expected behavior

Default
Keyed
AnyKey

Actual behavior

Default
Default
Default

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	pengweiqhca
Assignees:	-
Labels:	area-Extensions-DependencyInjection
Milestone:	-

[buyaa-n]

@benjaminpetit PTAL

[benjaminpetit]

Keys are not "transitives", it would be super hard to understand the flow otherwise IMO.

What you could do is something like this when registering B:

services.AddSingleton(_ => new A("Default"))
    .AddKeyedSingleton(KeyedService.AnyKey, (_, _) => new A("AnyKey"))
    .AddKeyedSingleton("Keyed", (_, _) => new A("Keyed"))
    .AddSingleton<B>().AddKeyedSingleton<B>(KeyedService.AnyKey, (sp, key) => new B(sp.GetRequiredKeyedService<A>(key));

[pengweiqhca]

Keys are not "transitives", it would be super hard to understand the flow otherwise IMO.

What you could do is something like this when registering B:

services.AddSingleton(_ => new A("Default"))
    .AddKeyedSingleton(KeyedService.AnyKey, (_, _) => new A("AnyKey"))
    .AddKeyedSingleton("Keyed", (_, _) => new A("Keyed"))
    .AddSingleton<B>().AddKeyedSingleton<B>(KeyedService.AnyKey, (sp, key) => new B(sp.GetRequiredKeyedService<A>(key));

If I have C, D, E ... , it is a hell! And It will lose the convenience of DI.