CI unable to find file copied from runtime-assets

[stephentoub]

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=535117
Build error leg or test failing: System.Text.RegularExpressions.Tests.RegexKnownPatternTests.PatternsDataSet_ConstructRegexForAll
Pull request: #97283

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "System.IO.FileNotFoundException : Could not find file.*Regex_RealWorldPatterns.json",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=535117
Error message validated: System.IO.FileNotFoundException : Could not find file.*Regex_RealWorldPatterns.json
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 1/22/2024 2:09:37 PM UTC

Report

Build	Definition	Test	Pull Request
535117	dotnet/runtime	System.Text.RegularExpressions.Tests.RegexKnownPatternTests.PatternsDataSet_ConstructRegexForAll	#97283

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
1	1	1

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=535117
Build error leg or test failing: System.Text.RegularExpressions.Tests.RegexKnownPatternTests.PatternsDataSet_ConstructRegexForAll
Pull request: #97283

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "System.IO.FileNotFoundException : Could not find file",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Author:	stephentoub
Assignees:	-
Labels:	blocking-clean-ci, area-Infrastructure, Known Build Error
Milestone:	-

[akoeplinger]

Pretty sure this is because of this test which was added in #96462 since it uses Environment.CurrentDirectory = TestDirectory; and if another test runs concurrently the working directory will be different:

runtime/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/Regex.CompileToAssembly.Tests.cs

Lines 42 to 69 in 86f25ad

	[ConditionalFact(nameof(IsDebug))]
	public void CompileToAssembly_SimpleUseInDebug()
	{
	(RegexCompilationInfo rci, string validInput, string invalidInput)[] regexes =
	[
	(new RegexCompilationInfo("abcd", RegexOptions.None, "Type1", "Namespace1", ispublic: true), "123abcd123", "123abed123"),
	(new RegexCompilationInfo("(a|b|cde)+", RegexOptions.None, "Type2", "Namespace2.Sub", ispublic: true), "abcde", "cd"),
	];
	string assemblyName = Path.GetRandomFileName();
	string cwd = Environment.CurrentDirectory;
	Environment.CurrentDirectory = TestDirectory;
	try
	{
	Regex.CompileToAssembly(regexes.Select(r => r.rci).ToArray(), new AssemblyName(assemblyName));
	}
	finally
	{
	Environment.CurrentDirectory = cwd;
	}
	string assemblyPath = Path.Combine(TestDirectory, assemblyName + ".dll");
	Assert.True(File.Exists(assemblyPath));
	// Uncomment to save the assembly to the desktop for inspection:
	// File.Copy(assemblyPath, Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.DesktopDirectory), Path.GetFileName(assemblyPath)));
	}

Other tests which modify CurrentDirectory do so in a RemoteExecutor, @stephentoub would that be acceptable here or does it interfere with the "simple" use case of this test?

[ViktorHofer]

This seems to be an issue specific to the Regex test invocation. I can see the Regex_RealWorldPatterns.json file in the test payload folder (the test output directory that gets sent to Helix to run the test):

Payload URL: https://helixde107v0xdeko0k025g8.blob.core.windows.net/helix-job-efb12d6f-348f-4962-a382-df1277914ca47d8fcc2dcf04fccba/System.Text.RegularExpressions.Tests.zip?helixlogtype=result

Looking at the path /private/tmp/helix/working/A43408F3/t/#RegexCompileToAssemblyTests_yiwsruqa.fkz/Regex_RealWorldPatterns.json, I'm not sure if that's the right path based on the console log. /private/tmp/helix/working/A43408F3/w/B74809A4/e seems to be the folder that contains the json file.

[stephentoub]

@akoeplinger is likely right. I'll fix.

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=535117
Build error leg or test failing: System.Text.RegularExpressions.Tests.RegexKnownPatternTests.PatternsDataSet_ConstructRegexForAll
Pull request: #97283

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "System.IO.FileNotFoundException : Could not find file.*Regex_RealWorldPatterns.json",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=535117
Error message validated: System.IO.FileNotFoundException : Could not find file.*Regex_RealWorldPatterns.json
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 1/22/2024 2:09:37 PM UTC

Report

Build	Definition	Test	Pull Request
535117	dotnet/runtime	System.Text.RegularExpressions.Tests.RegexKnownPatternTests.PatternsDataSet_ConstructRegexForAll	#97283

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
1	1	1

Author:	stephentoub
Assignees:	-
Labels:	area-System.Text.RegularExpressions, blocking-clean-ci, untriaged, Known Build Error
Milestone:	-