Keyed services aren't working with HttpClientBuilder

[xakep139]

Description

It seems that IHttpClientFactory doesn't support newly added #64427.

Reproduction Steps

var services = new ServiceCollection();
var httpClientBuilder = services
    .AddHttpClient("named");

httpClientBuilder.Services.TryAddKeyedSingleton<MyClientLogger>(httpClientBuilder.Name);
httpClientBuilder.AddLogger(sp => sp.GetRequiredKeyedService<HttpClientLogger>(httpClientBuilder.Name));

using var provider = services.BuildServiceProvider();

var httpClientFactory = provider.GetRequiredService<IHttpClientFactory>();
using var httpClient = httpClientFactory.CreateClient("named");

And MyLogger simply implements IHttpClientLogger.

Expected behavior

No exception is thrown.

Actual behavior

System.InvalidOperationException is thrown with the next message: This service provider doesn't support keyed services.

Stack Trace:

    ServiceProviderKeyedServiceExtensions.GetRequiredKeyedService(IServiceProvider provider, Type serviceType, Object serviceKey)
    ServiceProviderKeyedServiceExtensions.GetRequiredKeyedService[T](IServiceProvider provider, Object serviceKey)
    <>c__DisplayClass25_0.<Test_test>b__0(IServiceProvider sp) line 773
    <>c__DisplayClass27_0.<AddLogger>b__1(HttpMessageHandlerBuilder b)
    <>c__DisplayClass17_0.<CreateHandlerEntry>g__Configure|0(HttpMessageHandlerBuilder b)
    <>c__DisplayClass3_0.<Configure>b__0(HttpMessageHandlerBuilder builder)
    DefaultHttpClientFactory.CreateHandlerEntry(String name)
    <.ctor>b__1()
    Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
    Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
    Lazy`1.CreateValue()
    DefaultHttpClientFactory.CreateHandler(String name)
    DefaultHttpClientFactory.CreateClient(String name)
    MyTests.Test() line 778
    RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
    MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

Regression?

No response

Known Workarounds

No response

Configuration

.NET SDK 8.0.100-preview.7.23360.1
I was referencing runtime packages with version 8.0.0-rc.1.23373.2.

Other information

I haven't tried, but the same issue could probably be the case when ConfigureHttpClientDefaults() is used and in its configure action a keyed service is registered/resolved.

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

It seems that IHttpClientFactory doesn't support newly added #64427.

Reproduction Steps

var services = new ServiceCollection();
var httpClientBuilder = services
    .AddHttpClient("named");

httpClientBuilder.Services.TryAddKeyedSingleton<MyClientLogger>(httpClientBuilder.Name);
httpClientBuilder.AddLogger(sp => sp.GetRequiredKeyedService<HttpClientLogger>(httpClientBuilder.Name));

using var provider = services.BuildServiceProvider();

var httpClientFactory = provider.GetRequiredService<IHttpClientFactory>();
using var httpClient = httpClientFactory.CreateClient("named");

And MyLogger simply implements IHttpClientLogger.

Expected behavior

No exception is thrown.

Actual behavior

System.InvalidOperationException is thrown with the next message: This service provider doesn't support keyed services.

Stack Trace:

    ServiceProviderKeyedServiceExtensions.GetRequiredKeyedService(IServiceProvider provider, Type serviceType, Object serviceKey)
    ServiceProviderKeyedServiceExtensions.GetRequiredKeyedService[T](IServiceProvider provider, Object serviceKey)
    <>c__DisplayClass25_0.<Test_test>b__0(IServiceProvider sp) line 773
    <>c__DisplayClass27_0.<AddLogger>b__1(HttpMessageHandlerBuilder b)
    <>c__DisplayClass17_0.<CreateHandlerEntry>g__Configure|0(HttpMessageHandlerBuilder b)
    <>c__DisplayClass3_0.<Configure>b__0(HttpMessageHandlerBuilder builder)
    DefaultHttpClientFactory.CreateHandlerEntry(String name)
    <.ctor>b__1()
    Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
    Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
    Lazy`1.CreateValue()
    DefaultHttpClientFactory.CreateHandler(String name)
    DefaultHttpClientFactory.CreateClient(String name)
    MyTests.Test() line 778
    RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
    MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

Regression?

No response

Known Workarounds

No response

Configuration

.NET SDK 8.0.100-preview.7.23360.1
I was referencing runtime packages with version 8.0.0-rc.1.23373.2.

Other information

I haven't tried, but the same issue could probably be the case when ConfigureHttpClientDefaults() is used and in its configure action a keyed service is registered/resolved.

Author:	xakep139
Assignees:	-
Labels:	area-Extensions-HttpClientFactory
Milestone:	-

[xakep139]

cc @CarnaViire @klauco

[CarnaViire]

There are two issues here.

1. The reason for the repro attached here -- Scoped ServiceProvider, acquired from a DI scope created by IServiceScopeFactory, does not implement the IKeyedServiceProvider (see ServiceProviderEngineScope.cs) -- I will create a separate issue for that in Microsoft.Extensions.DependencyInjection space (UPD: Injected or scoped ServiceProvider does not support Keyed services #89447)
2. ConfigueHttpClientDefaults utilize a proxy service collection, which possibly should also support the interface -- this is an issue in Microsoft.Extensions.Http space, I will keep the current issue for tracking that.

UPD: there's no issue with ConfigueHttpClientDefaults, see comment below

[CarnaViire]

So, thinking this through, there's actually no second issue. ConfigueHttpClientDefaults utilize a proxy service collection, not a service provider. There's no problem with that, the interface should only be implemented by a service provider.

I've checked that keyed services work just fine with a custom service collection.

[CarnaViire]

@xakep139 I'm considering closing this as a duplicate of #89447, as there's nothing needs to be changed in HttpClientFactory.

Sadly there's no workaround I see, even suppressing scopes wouldn't help 😢 #89447 (comment)

[CarnaViire]

Duplicate of #89447