Microsoft.NET.ILLink package is broken

[marek-safar]

Microsoft.NET.ILLink package is broken since we moved illink repo to dotnet/runtime. The package is missing dependency of Mono.Cecil which blocks consumption of this package.

Extracted illink.nuspec from https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet8/NuGet/Microsoft.NET.ILLink/overview/8.0.0-preview.2.23123.8

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
  <metadata>
    <id>Microsoft.NET.ILLink</id>
    <version>8.0.0-preview.2.23123.8</version>
    <authors>Microsoft</authors>
    <license type="expression">MIT</license>
    <licenseUrl>https://licenses.nuget.org/MIT</licenseUrl>
    <icon>Icon.png</icon>
    <projectUrl>https://dot.net/</projectUrl>
    <description>IL Linker</description>
    <releaseNotes>https://go.microsoft.com/fwlink/?LinkID=799421</releaseNotes>
    <copyright>© Microsoft Corporation. All rights reserved.</copyright>
    <serviceable>true</serviceable>
    <repository type="git" url="https://github.com/dotnet/runtime" commit="c72a060e67453703172be1f886b651f1f89de562" />
    <dependencies>
      <group targetFramework="net8.0" />
    </dependencies>
  </metadata>
</package>

Open question is if the dependency should be Mono.Cecil or Microsoft.DotNet.Cecil package.

@grendello @rolfbjarne

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Microsoft.NET.ILLink package is broken since we moved illink repo to dotnet/runtime. The package is missing dependency of Mono.Cecil which blocks consumption of this package.

Extracted illink.nuspec from https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet8/NuGet/Microsoft.NET.ILLink/overview/8.0.0-preview.2.23123.8

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
  <metadata>
    <id>Microsoft.NET.ILLink</id>
    <version>8.0.0-preview.2.23123.8</version>
    <authors>Microsoft</authors>
    <license type="expression">MIT</license>
    <licenseUrl>https://licenses.nuget.org/MIT</licenseUrl>
    <icon>Icon.png</icon>
    <projectUrl>https://dot.net/</projectUrl>
    <description>IL Linker</description>
    <releaseNotes>https://go.microsoft.com/fwlink/?LinkID=799421</releaseNotes>
    <copyright>© Microsoft Corporation. All rights reserved.</copyright>
    <serviceable>true</serviceable>
    <repository type="git" url="https://github.com/dotnet/runtime" commit="c72a060e67453703172be1f886b651f1f89de562" />
    <dependencies>
      <group targetFramework="net8.0" />
    </dependencies>
  </metadata>
</package>

Open question is if the dependency should be Mono.Cecil or Microsoft.DotNet.Cecil package.

@grendello @rolfbjarne

Author:	marek-safar
Assignees:	-
Labels:	untriaged, area-Tools-ILLink
Milestone:	-

[sbomer]

I'm adding a dependency on Microsoft.DotNet.Cecil in #82630. I believe this is the right choice because it's the officially supported version of the package, but it may require consumers in xamarin to also reference that package instead of Mono.Cecil. We didn't change any assembly or type names, so no code should need to be updated.

[rolfbjarne]

@sbomer @marek-safar which feed is the Microsoft.DotNet.Cecil package in? I'm getting error NU1101: Unable to find package Microsoft.DotNet.Cecil

And these are the feeds we have right now:

    https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json
    https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json
    https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json
    https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json
    https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json
    https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json
    https://pkgs.dev.azure.com/xamarin/public/_packaging/macios-dependencies/nuget/v3/index.json
    https://pkgs.dev.azure.com/azure-public/vside/_packaging/xamarin-impl/nuget/v3/index.json
    https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-3f6c45a2/nuget/v3/index.json
    https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-531f715f/nuget/v3/index.json
    https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-8c6bcad1/nuget/v3/index.json
    https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-f2980ae1/nuget/v3/index.json
    https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-15d285f3/nuget/v3/index.json
    https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-d5edd29b-1/nuget/v3/index.json
    https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-2e45bc7a/nuget/v3/index.json

[marek-safar]

It's now only available at transport feed (we should enable it to internal too @sbomer?)

Try to add this

https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8-transport/nuget/v3/index.json

[sbomer]

By internal do you mean the dotnet8 feed? I think it should only go on the transport feed since the dotnet8 feed is intended for packages that will eventually make it to nuget.org. (Microsoft.NET.ILLink.Tasks, on the other hand, has to go to nuget.org so that the SDK can pull down the right version of ILLink based on the TFM).

[marek-safar]

@sbomer I think it's worth double checking on this. I think Microsoft.NET.ILLink is available on dotnet8 feed but its dependencies are not, which feels odd.