Binding collection is not working for options in .net 7.0.1 - it is working in version 7.0.0 and below

[msmolka]

Description

I have following code for options:
https://github.com/msmolka/ZNetCS.AspNetCore.IPFiltering/blob/c4f6d097351e2d40126cd4be67d506e4fae6b1b3/src/ZNetCS.AspNetCore.IPFiltering/OptionBase.cs

Above code works properly in version 7.0.0 and below

However after applying 7.0.1 patch it stopped working.
We had to change code to following:

https://github.com/msmolka/ZNetCS.AspNetCore.IPFiltering/blob/4434801b441d3d8ba93c00649be148df52b43ed5/src/ZNetCS.AspNetCore.IPFiltering/OptionBase.cs

Reproduction Steps

Grab repo at point:
https://github.com/msmolka/ZNetCS.AspNetCore.IPFiltering/tree/f60a40de740681ed58cbd9906dcf46466f7513e6

2 test are failing for .net 7.0 (only after applying patch). They are passing before applying 7.0.1 patch

Expected behavior

There are no braking changes in patch version

Actual behavior

Breaking changes in patch version

Regression?

it is working on version 7.0.0. and below

Known Workarounds

https://github.com/msmolka/ZNetCS.AspNetCore.IPFiltering/blob/master/src/ZNetCS.AspNetCore.IPFiltering/OptionBase.cs

Configuration

No response

Other information

No response

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[jeffschwMSFT]

@msmolka thanks for providing the code with tests. Can you provide a small repro that highlights what is happening and what you would expect to happen?

This issue has been marked needs-author-action and may be missing some important information.

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

I have following code for options:
https://github.com/msmolka/ZNetCS.AspNetCore.IPFiltering/blob/c4f6d097351e2d40126cd4be67d506e4fae6b1b3/src/ZNetCS.AspNetCore.IPFiltering/OptionBase.cs

Above code works properly in version 7.0.0 and below

However after applying 7.0.1 patch it stopped working.
We had to change code to following:

https://github.com/msmolka/ZNetCS.AspNetCore.IPFiltering/blob/4434801b441d3d8ba93c00649be148df52b43ed5/src/ZNetCS.AspNetCore.IPFiltering/OptionBase.cs

Reproduction Steps

Grab repo at point:
https://github.com/msmolka/ZNetCS.AspNetCore.IPFiltering/tree/f60a40de740681ed58cbd9906dcf46466f7513e6

2 test are failing for .net 7.0 (only after applying patch). They are passing before applying 7.0.1 patch

Expected behavior

There are no braking changes in patch version

Actual behavior

Breaking changes in patch version

Regression?

it is working on version 7.0.0. and below

Known Workarounds

https://github.com/msmolka/ZNetCS.AspNetCore.IPFiltering/blob/master/src/ZNetCS.AspNetCore.IPFiltering/OptionBase.cs

Configuration

No response

Other information

No response

Author:	msmolka
Assignees:	-
Labels:	untriaged, area-Extensions-HttpClientFactory, needs-author-action
Milestone:	-

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

I have following code for options:
https://github.com/msmolka/ZNetCS.AspNetCore.IPFiltering/blob/c4f6d097351e2d40126cd4be67d506e4fae6b1b3/src/ZNetCS.AspNetCore.IPFiltering/OptionBase.cs

Above code works properly in version 7.0.0 and below

However after applying 7.0.1 patch it stopped working.
We had to change code to following:

https://github.com/msmolka/ZNetCS.AspNetCore.IPFiltering/blob/4434801b441d3d8ba93c00649be148df52b43ed5/src/ZNetCS.AspNetCore.IPFiltering/OptionBase.cs

Reproduction Steps

Grab repo at point:
https://github.com/msmolka/ZNetCS.AspNetCore.IPFiltering/tree/f60a40de740681ed58cbd9906dcf46466f7513e6

2 test are failing for .net 7.0 (only after applying patch). They are passing before applying 7.0.1 patch

Expected behavior

There are no braking changes in patch version

Actual behavior

Breaking changes in patch version

Regression?

it is working on version 7.0.0. and below

Known Workarounds

https://github.com/msmolka/ZNetCS.AspNetCore.IPFiltering/blob/master/src/ZNetCS.AspNetCore.IPFiltering/OptionBase.cs

Configuration

No response

Other information

No response

Author:	msmolka
Assignees:	-
Labels:	untriaged, area-Extensions-Options, needs-author-action
Milestone:	-

[gao-artur]

I am hitting the same issue. The setter will be executed only when the corresponding property exists in the configuration source.
For example:

public class MyOptions
{
    private int _numOfRetries;
    public int NumOfRetries
    {
        get => _numOfRetries;
        set => _numOfRetries = value != 0 ? value : 5;
    }
}

var myOptions = configuration.GetSection("MyOptions").Get<MyOptions>();

In .NET 6, when the MyOptions:NumOfRetries is not defined in any configuration source, the setter is executed and NumOfRetries = 5. In .NET 7.0.1 the setter is not executed and NumOfRetries = 0

[tarekgh]

@msmolka @gao-artur could you please provide a complete code sample reproducing the issue? Thanks!

Also, could you try the same repo with the following version of the library and let me know?

    <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.0-alpha.1.22578.1" />

from the nuget feed:

    <add key="dotnet8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json" />