Test failure System.IO.Tests.InternalBufferSizeTests.FileSystemWatcher_InternalBufferSize_SynchronizingObject

[VincentBu]

Run: runtime-coreclr libraries-jitstress 20220425.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstress1_tiered-Windows.10.Amd64.Open

- System.IO.Tests.InternalBufferSizeTests.FileSystemWatcher_InternalBufferSize_SynchronizingObject

Error message:

Did not observe an error event within 500ms and 3 attempts.
Expected: True
Actual:   False


Stack trace
   at System.IO.Tests.FileSystemWatcherTest.ExpectError(FileSystemWatcher watcher, Action action, Action cleanup, Int32 attempts) in /_/src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs:line 369
   at System.IO.Tests.InternalBufferSizeTests.FileSystemWatcher_InternalBufferSize_SynchronizingObject() in /_/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs:line 84
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.RuntimeMethodInfo.InvokeNonEmitUnsafe(Object obj, IntPtr* arguments, Span`1 argsForTemporaryMonoSupport, BindingFlags invokeAttr) in /_/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs:line 383

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Run: runtime-coreclr libraries-jitstress 20220425.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstress1_tiered-Windows.10.Amd64.Open

- System.IO.Tests.InternalBufferSizeTests.FileSystemWatcher_InternalBufferSize_SynchronizingObject

Error message:

Did not observe an error event within 500ms and 3 attempts.
Expected: True
Actual:   False


Stack trace
   at System.IO.Tests.FileSystemWatcherTest.ExpectError(FileSystemWatcher watcher, Action action, Action cleanup, Int32 attempts) in /_/src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs:line 369
   at System.IO.Tests.InternalBufferSizeTests.FileSystemWatcher_InternalBufferSize_SynchronizingObject() in /_/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs:line 84
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.RuntimeMethodInfo.InvokeNonEmitUnsafe(Object obj, IntPtr* arguments, Span`1 argsForTemporaryMonoSupport, BindingFlags invokeAttr) in /_/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs:line 383

Author:	VincentBu
Assignees:	-
Labels:	arch-x86, area-System.IO, os-windows, JitStress
Milestone:	-

[jozkee]

This test was added in #53151, it appears that on RecreateWatcher, we don't set Changed on the new FSW,

runtime/src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs

Lines 468 to 478 in b490c47

	private static FileSystemWatcher RecreateWatcher(FileSystemWatcher watcher)
	{
	FileSystemWatcher newWatcher = new FileSystemWatcher()
	{
	IncludeSubdirectories = watcher.IncludeSubdirectories,
	NotifyFilter = watcher.NotifyFilter,
	Path = watcher.Path,
	InternalBufferSize = watcher.InternalBufferSize,
	SynchronizingObject = watcher.SynchronizingObject,
	};

which in this test is used to wait for the action to finish after the 10 times it changes the file,

runtime/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs

Lines 106 to 112 in b490c47

	// generate enough file change events to overflow the default buffer
	for (int i = 1; i < internalBufferOperationCapacity * 10; i++)
	{
	File.SetLastWriteTime(filePath, DateTime.Now + TimeSpan.FromSeconds(i));
	}
	unblockHandler.Set();

runtime/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs

Lines 93 to 94 in b490c47

	// block the handling thread
	watcher.Changed += (o, e) => unblockHandler.WaitOne();

so that means that we only achieve it on the first attempt, but not for subsequent ones.

[jozkee]

cc @thomsj @stephentoub

[v-wenyuxu]

Failed again in: runtime-coreclr libraries-jitstress 20221031.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstress1-Windows.10.Amd64.Open

- System.IO.Tests.InternalBufferSizeTests.FileSystemWatcher_InternalBufferSize_SynchronizingObject

Error message:

Did not observe an error event within 500ms and 3 attempts.
Expected: True
Actual:   False


Stack trace
   at System.IO.Tests.FileSystemWatcherTest.ExpectError(FileSystemWatcher watcher, Action action, Action cleanup, Int32 attempts) in /_/src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs:line 369
   at System.IO.Tests.InternalBufferSizeTests.FileSystemWatcher_InternalBufferSize_SynchronizingObject() in /_/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs:line 82
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr) in /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs:line 64

[v-wenyuxu]

Failed again in: runtime-coreclr libraries-jitstress 20230208.1

Failed test:

net8.0-windows-Release-x86-CoreCLR_checked-jitstress2-Windows.10.Amd64.Open

- System.IO.Tests.InternalBufferSizeTests.FileSystemWatcher_InternalBufferSize_SynchronizingObject

Error message:

Did not observe an error event within 500ms and 3 attempts.
Expected: True
Actual:   False


Stack trace
   at System.IO.Tests.FileSystemWatcherTest.ExpectError(FileSystemWatcher watcher, Action action, Action cleanup, Int32 attempts) in /_/src/libraries/System.IO.FileSystem.Watcher/tests/Utility/FileSystemWatcherTest.cs:line 369
   at System.IO.Tests.InternalBufferSizeTests.FileSystemWatcher_InternalBufferSize_SynchronizingObject() in /_/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs:line 82
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr) in /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs:line 59