Repeatedly initialize the static variables s_defaultSimpleConverters and s_defaultFactoryConverters when calling the method GetConverter of JsonSerializerOptions

[dczuo]

Description

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Converters.cs

Line 162 in a1a653c

RootBuiltInConverters();

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Converters.cs

Line 27 in a1a653c

private static void RootBuiltInConverters()

Reproduction Steps

According to the referenced code

Expected behavior

Variables s_defaultSimpleConverters and s_defaultFactoryConverters are initialized only once

Actual behavior

Variables s_defaultSimpleConverters and s_defaultFactoryConverters are repeatedly initialized with each call

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Converters.cs

Line 162 in a1a653c

RootBuiltInConverters();

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Converters.cs

Line 27 in a1a653c

private static void RootBuiltInConverters()

Reproduction Steps

According to the referenced code

Expected behavior

Variables s_defaultSimpleConverters and s_defaultFactoryConverters are initialized only once

Actual behavior

Variables s_defaultSimpleConverters and s_defaultFactoryConverters are repeatedly initialized with each call

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	dczuo
Assignees:	-
Labels:	area-System.Text.Json, untriaged
Milestone:	-

[eiriktsarpalis]

Good catch, thanks. It should be possible to fix the issue by adding a null check in the RootBuiltInConverters method. Would you be interested in contributing a PR?

[EgorBo]

Seems to be introduced in https://github.com/dotnet/runtime/pull/57327/files#r688365200

(screenshot, because github links for PR's parts are terrible)