ZipArchive corrupts files with unicode characters

[pranavkm]

Description

Discovered this as part of a SDK upgrade in the dotnet/aspnetcore repo. AspNetCore has test assets with unicode chars that get bundled up by Helix:

• https://github.com/dotnet/aspnetcore/tree/main/src/Middleware/StaticFiles/test/UnitTests/SubFolder/%E4%BD%A0%E5%A5%BD/%E4%B8%96%E7%95%8C
• https://github.com/dotnet/arcade/blob/dd1e882f0945121bd0786b4894073db2bd45274c/src/Microsoft.DotNet.Helix/JobSender/Payloads/DirectoryPayload.cs#L53-L68

Updating to the latest SDK causes the folder to be corrupted and our tests to fail:

Reproduction Steps

Run this app using the latest runtime: https://github.com/pranavkm/zip-file

Expected behavior

Archive should preserve unicode characters

Actual behavior

They are garbled

Regression?

Regression from 7.0-preview2 runtime

Known Workarounds

No response

Configuration

No response

Other information

No response

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[pranavkm]

@carlossanlop perhaps this is related to your recent change: https://github.com/dotnet/runtime/pull/59442/files

[carlossanlop]

The entry name encoding may be changed if the comment encoding changes, and viceversa. Per the zip spec, this is the expected behavior, but the change I introduced could've also introduced a bug.

Do you know if the entry was added with a comment?

Tagging @dotnet/area-system-io-compression for awareness.

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Discovered this as part of a SDK upgrade in the dotnet/aspnetcore repo. AspNetCore has test assets with unicode chars that get bundled up by Helix:

• https://github.com/dotnet/aspnetcore/tree/main/src/Middleware/StaticFiles/test/UnitTests/SubFolder/%E4%BD%A0%E5%A5%BD/%E4%B8%96%E7%95%8C
• https://github.com/dotnet/arcade/blob/dd1e882f0945121bd0786b4894073db2bd45274c/src/Microsoft.DotNet.Helix/JobSender/Payloads/DirectoryPayload.cs#L53-L68

Updating to the latest SDK causes the folder to be corrupted and our tests to fail:

Reproduction Steps

Run this app using the latest runtime: https://github.com/pranavkm/zip-file

Expected behavior

Archive should preserve unicode characters

Actual behavior

They are garbled

Regression?

Regression from 7.0-preview2 runtime

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	pranavkm
Assignees:	-
Labels:	area-System.IO.Compression, untriaged
Milestone:	-

[dougbu]

Do you know if the entry was added with a comment?

The Helix SDK uses ZipArchive.ZipArchive(...) w/ a MemoryStream and adds files using ZipArchive.CreateEntryFromFile(...). See https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Helix/JobSender/Payloads/DirectoryPayload.cs

[pranavkm]

Ping @carlossanlop have you had a chance to look at this as yet? If not, are you open to rolling back your earlier change since it blocks SDK ingestion in to AspNetCore?