Test failure JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

[VincentBu]

Run: runtime-coreclr jitstress 20210928.2

Failed test;

CoreCLR OSX x64 Checked jitstress2 @ OSX.1014.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR OSX x64 Checked jitstress1_tiered @ OSX.1014.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR windows x64 Checked jitstress1_tiered @ Windows.10.Amd64.Open
- JIT\\Regression\\CLR-x86-JIT\\V2.0-Beta2\\b399444\\b399444b\\b399444b.cmd

CoreCLR OSX x64 Checked jitstress1 @ OSX.1014.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR windows x64 Checked jitstress1 @ Windows.10.Amd64.Open
- JIT\\Regression\\CLR-x86-JIT\\V2.0-Beta2\\b399444\\b399444b\\b399444b.cmd

CoreCLR OSX x64 Checked jitstress2_tiered @ OSX.1014.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR windows x64 Checked jitstress2 @ Windows.10.Amd64.Open
- JIT\\Regression\\CLR-x86-JIT\\V2.0-Beta2\\b399444\\b399444b\\b399444b.cmd

CoreCLR windows x64 Checked jitstress2_tiered @ Windows.10.Amd64.Open
- JIT\\Regression\\CLR-x86-JIT\\V2.0-Beta2\\b399444\\b399444b\\b399444b.cmd

CoreCLR Linux x64 Checked jitstress2 @ Ubuntu.1804.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR Linux x64 Checked jitstress1 @ Ubuntu.1804.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR Linux x64 Checked jitstress1_tiered @ Ubuntu.1804.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR Linux x64 Checked jitstress2_tiered @ Ubuntu.1804.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

Error message:

Assert failure(PID 50577 [0x0000c591], Thread: 4855581 [0x4a171d]): heapSize >= initialRequestSize
File: /Users/runner/work/1/s/src/coreclr/vm/codeman.cpp Line: 2276
Image: /private/tmp/helix/working/B5FB09E3/p/corerun

task_for_pid(50577) FAILED 5 (os/kern) failure
/private/tmp/helix/working/B5FB09E3/w/A5FE0972/e/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh: line 370: 50577 Abort trap: 6           (core dumped) $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}"

Return code:      1
Raw output file:      /tmp/helix/working/B5FB09E3/w/A5FE0972/uploads/Reports/JIT.Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.output.txt
Raw output:
BEGIN EXECUTION
/tmp/helix/working/B5FB09E3/p/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false b399444b.dll ''
Expected: 100
Actual: 134
END EXECUTION - FAILED
Test Harness Exitcode is : 1
To run the test:

set CORE_ROOT=/tmp/helix/working/B5FB09E3/p
/private/tmp/helix/working/B5FB09E3/w/A5FE0972/e/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh
Expected: True
Actual:   False


Stack trace
   at JIT_Regression._CLR_x86_JIT_V2_0_Beta2_b399444_b399444b_b399444b_._CLR_x86_JIT_V2_0_Beta2_b399444_b399444b_b399444b_sh()

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Run: runtime-coreclr jitstress 20210928.2

Failed test;

CoreCLR OSX x64 Checked jitstress2 @ OSX.1014.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR OSX x64 Checked jitstress1_tiered @ OSX.1014.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR windows x64 Checked jitstress1_tiered @ Windows.10.Amd64.Open
- JIT\\Regression\\CLR-x86-JIT\\V2.0-Beta2\\b399444\\b399444b\\b399444b.cmd

CoreCLR OSX x64 Checked jitstress1 @ OSX.1014.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR windows x64 Checked jitstress1 @ Windows.10.Amd64.Open
- JIT\\Regression\\CLR-x86-JIT\\V2.0-Beta2\\b399444\\b399444b\\b399444b.cmd

CoreCLR OSX x64 Checked jitstress2_tiered @ OSX.1014.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR windows x64 Checked jitstress2 @ Windows.10.Amd64.Open
- JIT\\Regression\\CLR-x86-JIT\\V2.0-Beta2\\b399444\\b399444b\\b399444b.cmd

CoreCLR windows x64 Checked jitstress2_tiered @ Windows.10.Amd64.Open
- JIT\\Regression\\CLR-x86-JIT\\V2.0-Beta2\\b399444\\b399444b\\b399444b.cmd

CoreCLR Linux x64 Checked jitstress2 @ Ubuntu.1804.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR Linux x64 Checked jitstress1 @ Ubuntu.1804.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR Linux x64 Checked jitstress1_tiered @ Ubuntu.1804.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

CoreCLR Linux x64 Checked jitstress2_tiered @ Ubuntu.1804.Amd64.Open
- JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh

Error message:

Assert failure(PID 50577 [0x0000c591], Thread: 4855581 [0x4a171d]): heapSize >= initialRequestSize
File: /Users/runner/work/1/s/src/coreclr/vm/codeman.cpp Line: 2276
Image: /private/tmp/helix/working/B5FB09E3/p/corerun

task_for_pid(50577) FAILED 5 (os/kern) failure
/private/tmp/helix/working/B5FB09E3/w/A5FE0972/e/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh: line 370: 50577 Abort trap: 6           (core dumped) $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}"

Return code:      1
Raw output file:      /tmp/helix/working/B5FB09E3/w/A5FE0972/uploads/Reports/JIT.Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.output.txt
Raw output:
BEGIN EXECUTION
/tmp/helix/working/B5FB09E3/p/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false b399444b.dll ''
Expected: 100
Actual: 134
END EXECUTION - FAILED
Test Harness Exitcode is : 1
To run the test:

set CORE_ROOT=/tmp/helix/working/B5FB09E3/p
/private/tmp/helix/working/B5FB09E3/w/A5FE0972/e/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/b399444b/b399444b.sh
Expected: True
Actual:   False


Stack trace
   at JIT_Regression._CLR_x86_JIT_V2_0_Beta2_b399444_b399444b_b399444b_._CLR_x86_JIT_V2_0_Beta2_b399444_b399444b_b399444b_sh()

Author:	VincentBu
Assignees:	-
Labels:	os-linux, os-mac-os-x, os-windows, JitStress, arch-x64, area-CodeGen-coreclr, untriaged
Milestone:	-

[JulieLeeMSFT]

@mangod9 could your team take a look? The error is in codeman.cpp.
CC @dotnet/jit-contrib

[BruceForstall]

@janvorli This appears to be related to some changes you made in #52912, in particular around:

runtime/src/coreclr/vm/codeman.cpp

Lines 2254 to 2276 in ce99c56

	// this first allocation is critical as it sets up correctly the loader heap info
	HeapList *pHp = new HeapList;
	#if defined(TARGET_AMD64) || defined(TARGET_ARM64)
	pHp->CLRPersonalityRoutine = (BYTE *)pCodeHeap->m_LoaderHeap.AllocMem(JUMP_ALLOCATE_SIZE);
	#else
	// Ensure that the heap has a reserved block of memory and so the GetReservedBytesFree()
	// and GetAllocPtr() calls below return nonzero values.
	pCodeHeap->m_LoaderHeap.ReservePages(1);
	#endif
	pHp->pHeap = pCodeHeap;
	size_t heapSize = pCodeHeap->m_LoaderHeap.GetReservedBytesFree();
	size_t nibbleMapSize = HEAP2MAPSIZE(ROUND_UP_TO_PAGE(heapSize));
	pHp->startAddress = (TADDR)pCodeHeap->m_LoaderHeap.GetAllocPtr();
	pHp->endAddress = pHp->startAddress;
	pHp->maxCodeHeapSize = heapSize;
	pHp->reserveForJumpStubs = fAllocatedFromEmergencyJumpStubReserve ? pHp->maxCodeHeapSize : GetDefaultReserveForJumpStubs(pHp->maxCodeHeapSize);
	_ASSERTE(heapSize >= initialRequestSize);

For this test, but only under JitStress apparently (due to different codegen and thus code space allocation request), there is a problem where the allocated size is too small. We start with:

Name	Value
m_requestSize	0x000000000013ffff
m_reserveSize	0x0000000000140000

So, the requestSize (rounded up in various ways, plus some alignment padding) is just 1 less than the rounded-up reserveSize. But the:

pHp->CLRPersonalityRoutine = (BYTE *)pCodeHeap->m_LoaderHeap.AllocMem(JUMP_ALLOCATE_SIZE);

line takes 16 bytes out of the allocation, so we end up with:

Name	Value
heapSize	0x000000000013fff0
initialRequestSize	0x000000000013ffff

and then:

_ASSERTE(heapSize >= initialRequestSize);

fails.