[QUIC] MsQuicStream ctor code shuffles

We should move this before callback handler registration.
https://github.com/dotnet/runtime/blob/f59a132bfe9ff797f9d192d67f07673a13b6b29e/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs#L120-L124

We should set it before SetCallbackHandlerDelegate since we can get CONNECTION_CLOSED event and that needs this.
If we want to prevent decrementing stream count, we should explicitely unset here.
https://github.com/dotnet/runtime/blob/f59a132bfe9ff797f9d192d67f07673a13b6b29e/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs#L126

The same applies to outbound ctor.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QUIC] MsQuicStream ctor code shuffles #55815

ManickaP
openedon Jul 16, 2021

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (!connectionState.TryAddStream(this))
	{
	_state.StateGCHandle.Free();
	throw new ObjectDisposedException(nameof(QuicConnection));
	}

[QUIC] MsQuicStream ctor code shuffles #55815

Description

ManickaPopenedon Jul 16, 2021

Metadata