Obsolete CryptoConfig.EncodeOID

[vcsjones]

Background and Motivation

Inspired by #54087. We have CryptoConfig.EncodeOID to encoding an OID to ASN.1 DER. However it has a number of quirks in the way that it parses strings.

• It does not handle the first two arcs correctly (e.g. 41.41.41.41)
• "Supports" negative arcs.
• Doesn't handle large integers.
• etc

Now that there is System.Formats.Asn1, we have better tools for developers to use. I don't see any place within the Libraries that require developers to give us those bytes from EncodeOID, so there does not seem to be a case to keep using it, unless you are unintentionally giving it invalid OIDs.

Proposed API

namespace System.Security.Cryptography {
    public partial class CryptoConfig {
+       [Obsolete("EncodeOID is obsolete. Use the ASN.1 functionality provided in System.Formats.Asn1.")]
        public static byte[] EncodeOID(string str);
    }
}

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Background and Motivation

Inspired by #54087. We have CryptoConfig.EncodeOID to encoding an OID to ASN.1 DER. However it has a number of quirks in the way that it parses strings.

• It does not handle the first two arcs correctly (e.g. 41.41.41.41)
• "Supports" negative arcs.
• Doesn't handle large integers.
• etc

Now that there is System.Formats.Asn1, we have better tools for developers to use. I don't see any place within the Libraries that require developers to give us those bytes from EncodeOID, so there does not seem to be a case to keep using it, unless you are unintentionally giving it invalid OIDs.

Proposed API

namespace System.Security.Cryptography {
    public partial class CryptoConfig {
+       [Obsolete("EncodeOID is obsolete. Use the ASN.1 functionality provided in to System.Formats.Asn1 package.")]
        public static byte[] EncodeOID(string str);
    }
}

<table>
  <tr>
    <th align="left">Author:</th>
    <td>vcsjones</td>
  </tr>
  <tr>
    <th align="left">Assignees:</th>
    <td>-</td>
  </tr>
  <tr>
    <th align="left">Labels:</th>
    <td>

`api-suggestion`, `area-System.Security`, `untriaged`

</td>
  </tr>
  <tr>
    <th align="left">Milestone:</th>
    <td>-</td>
  </tr>
</table>
</details>

[terrajobst]

• Looks good as proposed
• Just dispense another diagnostic ID :-)

namespace System.Security.Cryptography
{
    public partial class CryptoConfig
    {
        [Obsolete("EncodeOID is obsolete. Use the ASN.1 functionality provided in System.Formats.Asn1.")]
        public static byte[] EncodeOID(string str);
    }
}

[bartonjs]

@vcsjones From the self assignment I assume you saw I set this as 6.0 and are starting on it now. 😄

[vcsjones]

From the self assignment I assume you saw I set this as 6.0 and are starting on it now. 😄

Almost done.