Skip to content

SerialStream doesn't override memory-based Read-/WriteAsync methods #54575

Closed
@ViktorHofer

Description

@ViktorHofer

When adding a NetCoreAppCurrent configuration to System.IO.Ports, roslyn warns that SerialStream's memory-based ReadAsync and WriteAsync methods aren't overridden. I was unsure if this requires api-approval so I'm filing this issue.

/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.cs(13,35): error CA1844: 'SerialStream' overrides array-based 'ReadAsync' but does not override memory-based 'ReadAsync'. Consider overriding memory-based 'ReadAsync' to improve performance. [/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System.IO.Ports.csproj]
/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.cs(13,35): error CA1844: 'SerialStream' overrides array-based 'WriteAsync' but does not override memory-based 'WriteAsync'. Consider overriding memory-based 'WriteAsync' to improve performance. [/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System.IO.Ports.csproj]

cc @adamsitnik @carlossanlop @jozkee @jeffhandley

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions