R2R tests failing

[BruceForstall]

In the outerloop job, all platforms, during crossgen CORE_ROOT step, with:

88 / 260 (32%, 1 failed): failed in 99 msecs, exit code 33, expected 0: crossgen @/__w/1/s/artifacts/tests/coreclr/obj/Linux.x64.Checked/crossgen.out/Microsoft.Extensions.Logging.Generators.dll.rsp
!! Error: Could not load file or assembly 'Microsoft.CodeAnalysis, Version=3.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The located assembly's manifest definition does not match the assembly reference. (0x80131040 (FUSION_E_REF_DEF_MISMATCH))
  Microsoft (R) CoreCLR Native Image Generator - Version 6.0.0-ci
  Copyright (c) Microsoft Corporation.  All rights reserved.
!! Error compiling /__w/1/s/artifacts/tests/coreclr/Linux.x64.Checked/Tests/Core_Root/Microsoft.Extensions.Logging.Generators.dll: Could not find or load a specific file. (0x80131621 (COR_E_FILELOAD))
!! Error: compilation failed for "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Checked/Tests/Core_Root/Microsoft.Extensions.Logging.Generators.dll" (0x80131621)

starting with https://dev.azure.com/dnceng/public/_build/results?buildId=1093577&view=results

@dotnet/crossgen-contrib Any crossgen changes that might have caused this? Or something else?

[mangod9]

hmm weird, this looks to be some sdk version mismatch. Wondering why its still using crossgen rather than crossgen2. cc @trylek

[jkotas]

This was introduce by #51064. Microsoft.Extensions.Logging.Generators should be excluded from Core_Root

[mangod9]

so should it be removed from being copied into Core_Root or excluded from being precompiled? I see references to tests/skipCrossGenFiles.* but no such files currently exist.

[jkotas]

so should it be removed from being copied into Core_Root or excluded from being precompiled?

or should all dependencies of the source generator be copied to core_root as well?

I do not know the answer to this question.

[mangod9]

thanks @trylek for the workaround to exclude this from being cg2-ed. Adding @maryamariyan to determine the right fix here to either exclude from Core_Root or include all dependencies too.

[maryamariyan]

I think this is related to comment: #51064 (comment)

cc: @safern @ericstj

[ericstj]

This is happening because the Cross-Gen tests are rather greedy with how they discover input to cross-gen. CORE_ROOT isn't a thing that the build process creates, it's constructed by these tests. Let me dig up how we've excluded things in the past.

[trylek]

I believe this is the place where we decide what to put in CORE_ROOT:

runtime/src/tests/Directory.Build.targets

Line 279 in 2aba0c5

<ItemGroup>