iOS (and other Apple platforms): the BCL has P/Invokes to libraries and/or functions that don't exist

[rolfbjarne]

Description

There are several DllImports in the BCL for iOS (and the other Apple platforms) that contain references to native functions that don't exist. It's highly preferable to not have any P/Invokes to native functions that don't exist, because it allows the AOT compiler to generate more efficient code. It also makes other performance improvements possible.

• System.Diagnostics.Process.dl

  • P/Invoke to SystemNative_ConfigureTerminalForChildProcess in libSystem.Native.dylib, but libSystem.Native.dylib doesn't provide that function. Tracked in Annotate APIs throwing PNSE on iOS/tvOS/MacCatalyst #47910

• System.Net.Quic.dll

  • MsQuicOpen Library: libmsquic.dylib

• System.Reflection.Metadata.dll

  • ReadFile Library: kernel32.dll

• System.Security.Cryptography.Algorithms.dll, System.Security.Cryptography.OpenSsl.dll and System.Security.Cryptography.X509Certificates.dll

  • Numerous references to functions in libSystem.Security.Cryptography.Native.Apple.dylib of the form AppleCryptoNative_* or CryptoNative_*. Tracked in Annotate APIs throwing PNSE on iOS/tvOS/MacCatalyst #47910

• System.Private.CoreLib.dll

  • Numerous references to functions in libSystem.Globalization.Native.dylib of the form GlobalizationNative_*. I believe this is because of pending work (issue #?)
  • Two functions from libhostpolicy.dylib(corehost_resolve_component_dependencies and corehost_set_error_writer). This has also been reported in iOS (and other Apple platforms): System.Private.CoreLib.dll has P/Invokes to a libhostpolicy library that isn't shipped #38543.

This is from the microsoft.netcore.app.runtime.ios-arm64 pack (6.0.0-alpha.1.21063.13).

Full output from custom tool I wrote: https://gist.github.com/rolfbjarne/b9a6f16d2a6697c0d8dfc46c39160404

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

There are several DllImports in the BCL that references to native functions that don't exist. It's highly preferable to not have any P/Invokes to native functions that don't exist, because it allows the AOT compiler to generate more efficient code. It also makes other performance improvements possible.

• System.Diagnostics.Process.dl

  • Has a P/Invoke to SystemNative_ConfigureTerminalForChildProcess in libSystem.Native.dylib, but libSystem.Native.dylib doesn't provide that function.

• System.Net.Quic.dll

  • Function: MsQuicOpen Library: libmsquic.dylib

• System.Net.Sockets.dll

  • Function: ReadFile Library: kernel32.dll

• System.Security.Cryptography.Algorithms.dll, System.Security.Cryptography.OpenSsl.dll and System.Security.Cryptography.X509Certificates.dll

  • Numerous references to functions in libSystem.Security.Cryptography.Native.Apple.dylib of the form AppleCryptoNative_* or CryptoNative_*. I believe this is because of pending work (issue #?)

• System.Private.CoreLib.dll

  • Numerous references to functions in libSystem.Globalization.Native.dylib of the form GlobalizationNative_*. I believe this is because of pending work (issue #?)
  • Two functions from libhostpolicy.dylib(corehost_resolve_component_dependencies and corehost_set_error_writer). This has also been reported in iOS (and other Apple platforms): System.Private.CoreLib.dll has P/Invokes to a libhostpolicy library that isn't shipped #38543.

This is from the microsoft.netcore.app.runtime.ios-arm64 pack (6.0.0-alpha.1.21063.13).

Full output from custom tool I wrote: https://gist.github.com/rolfbjarne/b9a6f16d2a6697c0d8dfc46c39160404

Author:	rolfbjarne
Assignees:	-
Labels:	area-System.Security, untriaged
Milestone:	-

[bartonjs]

System.Security.Cryptography.Algorithms.dll
    Library: libSystem.Security.Cryptography.Native.Apple.dylib Function: AppleCryptoNative_EccGenerateKey
        ❌ The function AppleCryptoNative_EccGenerateKey does not exist in libSystem.Security.Cryptography.Native.Apple.dylib

Yeah, functions like that one are conditional:

runtime/src/libraries/Native/Unix/System.Security.Cryptography.Native.Apple/pal_ecc.c

Lines 6 to 9 in 1d9e50c

	#if !defined(TARGET_IOS) && !defined(TARGET_TVOS)
	int32_t AppleCryptoNative_EccGenerateKey(
	int32_t keySizeBits, SecKeychainRef tempKeychain, SecKeyRef* pPublicKey, SecKeyRef* pPrivateKey, int32_t* pOSStatus)
	{

Just means that the relevant Interop.cs is being included in the iOS build when it doesn't need to.