Open
Description
openedon Dec 16, 2020
<ItemGroup Condition="'$(TargetOS)' == 'Browser'">
<!-- Create a work item for run-only WASM apps -->
<_RunOnlyWorkItem Include="$(TestArchiveRoot)runonly/**/*.zip" />
<HelixWorkItem Include="@(_RunOnlyWorkItem -> '%(FileName)')" >
<PayloadArchive>%(Identity)</PayloadArchive>
<!-- No RunTests script generated for the sample project so we just use the direct command -->
<Command>dotnet exec $XHARNESS_CLI_PATH wasm $XHARNESS_COMMAND --app=. --engine=V8 --engine-arg=--stack-trace-limit=1000 --js-file=runtime.js --output-directory=$XHARNESS_OUT -- --run WasmSample.dll</Command>
</HelixWorkItem>
</ItemGroup>Instead of this, we could try generating RunTests.sh which is done by
runtime/eng/testing/tests.targets
Lines 51 to 52 in 93e767b
Based on @safern's comment #45768 (comment)
I think I would rather do that and try to be consistent, it seems cumbersome to have that "workaround" in sendhelix to include the sample as part of the payload and hardcode the HelixCommand.
Can we open a follow up issue to clean this up and make it more generic for more samples? I see we also added this for iOS and it is doing somewhat similar instead of use the targets we already have.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
