Attempting to take a lock at shutdown that is not CRST_TAKEN_DURING_SHUTDOWN

[v-haren]

failed in job: runtime-coreclr outerloop 20201018.2

CoreCLR Windows_NT x64 Checked no_tiered_compilation @ Windows.10.Amd64.Open

Error message

Assert failure(PID 4556 [0x000011cc], Thread: 2396 [0x095c]): Attempting to take a lock at shutdown that is not CRST_TAKEN_DURING_SHUTDO
WN

CORECLR! CrstBase::PreEnter + 0x5C (0x00007ffde2d6eebc)
CORECLR! CrstBase::Enter + 0x202 (0x00007ffde2d6e102)
CORECLR! ClrEnterCriticalSection + 0xF4 (0x00007ffde3031360)
CORECLR! StressLog::Enter + 0x46 (0x00007ffde33b2b62)
CORECLR! StressLog::CreateThreadStressLog + 0x1C6 (0x00007ffde33b273e)
CORECLR! StressLog::LogMsg + 0x76 (0x00007ffde33b2eaa)
CORECLR! EEShutDownHelper + 0x78C (0x00007ffde34f94e4)
CORECLR! EEShutDown + 0x24B (0x00007ffde34f8cd7)
CORECLR! EEDllMain'::5'::__Body::Run + 0x14D (0x00007ffde34fbc89)
CORECLR! EEDllMain + 0x1F (0x00007ffde34f8a4f)
    File: F:\workspace\_work\1\s\src\coreclr\src\vm\crst.cpp Line: 402
    Image: C:\h\w\B7A40A41\p\CoreRun.exe


Return code:      1
Raw output file:      C:\h\w\B7A40A41\w\A9D00960\e\JIT\Methodical\Reports\JIT.Methodical\VT\callconv\_il_dbgvtret\_il_dbgvtret.output.txt
Raw output:
BEGIN EXECUTION
 "C:\h\w\B7A40A41\p\corerun.exe" _il_dbgvtret.dll 
Expected: 100
Actual: -1073740286
END EXECUTION - FAILED
FAILED
Test Harness Exitcode is : 1
To run the test:
> set CORE_ROOT=C:\h\w\B7A40A41\p
> C:\h\w\B7A40A41\w\A9D00960\e\JIT\Methodical\VT\callconv\_il_dbgvtret\_il_dbgvtret.cmd
Expected: True
Actual:   False


Stack trace
   at JIT_Methodical._VT_callconv__il_dbgvtret__il_dbgvtret_._VT_callconv__il_dbgvtret__il_dbgvtret_cmd() in F:\workspace\_work\1\s\artifacts\tests\coreclr\Windows_NT.x64.Checked\TestWrappers\JIT.Methodical\JIT.Methodical.XUnitWrapper.cs:line 187544

Build	Kind

[JulieLeeMSFT]

@CarolEidt PTAL this calling convention related assert.

[BruceForstall]

More cases of this: #43815

[CarolEidt]

@JulieLeeMSFT - I don't believe this is necessarily a calling convention related bug. It is failing with a locking failure in the runtime. Is there a reason to believe that this is codegen-related?

[JulieLeeMSFT]

CC @mangod9