CMP0068 CMake warning on mac

[hughbe]

Description

hugh@Hughs-MacBook-Air ~ % cmake --version
cmake version 3.17.3

CMake suite maintained and supported by Kitware (kitware.com/cmake).

hugh@Hughs-MacBook-Air runtime % ./build.sh -subset clr
  CMake Warning (dev):
    Policy CMP0068 is not set: RPATH settings on macOS do not affect
    install_name.  Run "cmake --help-policy CMP0068" for policy details.  Use
    the cmake_policy command to set the policy and suppress this warning.
  
    For compatibility with older versions of CMake, the install_name fields for
    the following targets are still affected by RPATH settings:
  
     mscordbi
  
  This warning is for project developers.  Use -Wno-dev to suppress it.

[Dotnet-GitSync-Bot]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

[danmoseley]

@mikem8361

[trylek]

@mikem8361 - is it safe to remove the "Untriaged" label from this issue or do we need to track this item in the infra backlog reviews for .NET 5?

[mikem8361]

@janvorli do you know if on MacOS x64 that we really need the mscordbi's RPATH in CMakeLists.txt? Removing the below two lines gets rid of the warning, but will it break anything? mscordac/coreclr modules on MacOS don't seem to have RPATHs.

--- a/src/coreclr/dlls/mscordbi/CMakeLists.txt
+++ b/src/coreclr/dlls/mscordbi/CMakeLists.txt
@@ -6,9 +6,6 @@ if(CORECLR_SET_RPATH)
     if(CLR_CMAKE_HOST_ARCH_ARM64)
       set(CMAKE_BUILD_WITH_INSTALL_NAME_DIR ON)
       set(CMAKE_INSTALL_NAME_DIR "@rpath")
-    else(CLR_CMAKE_HOST_ARCH_ARM64)
-      set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE)
-      set(CMAKE_INSTALL_RPATH "@loader_path")
     endif(CLR_CMAKE_HOST_ARCH_ARM64)
   else()
     set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE)

/cc: @sdmaclea

[sdmaclea]

See #51751.

You will probably find create dump will not find the dbi w/o it. I am adding similar lines to fix a broken PAL test on macOS.

[mikem8361]

Createdump only loads the DAC not DBI, but it sounds like removing RPATH make cause some problems loading in some of case.