[Perf -55%] PerfLabTests.StackWalk.Walk

[DrewScoggins]

Run Information

Architecture	x64
OS	ubuntu 18.04
Changes	diff

Regressions in PerfLabTests.StackWalk

Benchmark	Baseline	Test	Test/Base	Modality	Baseline Outlier
Walk	19.17 ms	29.60 ms	1.54		False

Related Issue on x86 Windows

[Perf -24%] PerfLabTests.StackWalk.Walk

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'PerfLabTests.StackWalk*';

Histogram

PerfLabTests.StackWalk.Walk

[17755496.482 ; 19727795.105) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[19727795.105 ; 21700093.729) | 
[21700093.729 ; 23672392.353) | 
[23672392.353 ; 25644690.977) | 
[25644690.977 ; 27440350.990) | 
[27440350.990 ; 28781134.731) | @@@@@@@@@
[28781134.731 ; 30753433.354) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[30753433.354 ; 32001389.496) | @@@@@@@@@@
[32001389.496 ; 34179137.166) | 
[34179137.166 ; 36151435.790) | @

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

[Dotnet-GitSync-Bot]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[stephentoub]

Locally I don't see -55%, but I do see -17% from .NET Core 3.1, as well as 48 bytes of allocation that wasn't showing up previously:

dotnet run -c Release -f netcoreapp3.1 --runtimes netcoreapp3.1 netcoreapp5.0 --join --filter *PerfLabTests.StackWalk.Walk*

Method	Job	Runtime	Toolchain	Mean	Error	StdDev	Median	Min	Max	Ratio	RatioSD	Gen 0	Gen 1	Gen 2	Allocated
Walk	Job-UZRDUN	.NET Core 3.1	netcoreapp3.1	31.71 ms	6.203 ms	7.143 ms	30.83 ms	22.33 ms	42.35 ms	1.00	0.00	1000000.0000	-	-	-
Walk	Job-TKJENW	.NET Core 5.0	netcoreapp5.0	35.11 ms	4.400 ms	4.708 ms	34.06 ms	29.97 ms	48.76 ms	1.17	0.29	1000000.0000	-	-	48 B

Tagging subscribers to this area: @tommcdon
Notify danmosemsft if you want to be subscribed.

[tommcdon]

@mikem8361 can you take a look?

[tommcdon]

@DrewScoggins we are running out of time in 5.0 to address issues. Any objection if we move this to .NET 6?

[DrewScoggins]

I would not call this ship-blocking, so moving it seems fine to me.