Missing API: Guid.TryWriteBytes(..., out int bytesWritten)

[GrabYourPitchforks]

Per API review, our Guid.TryWriteBytes method should have an overload which outs the number of bytes written to the destination buffer.

@tannergooding - you had also mentioned adding a similar API to decimal, but I don't see offhand which overload would be affected.

namespace System
{
    public partial struct Guid
    {
        public bool TryWriteBytes(Span<byte> destination, out int bytesWritten);
    }
}

[Wraith2]

I think that relates to https://github.com/dotnet/corefx/issues/35877 which would make it the public static bool TryGetBits(decimal d, Span<int> bits); overload to add an out for the bytes written.

[stephentoub]

@GrabYourPitchforks, @bartonjs, we should either just mark this as api-ready-for-review or close the issue :)

[dakersnar]

@GrabYourPitchforks @bartonjs bump, is this ready for review?

[bartonjs]

Added the missing member proposal, marked it ready for review.

Decimal's TryGetBits does have an out parameter: public static bool TryGetBits(decimal d, Span<int> destination, out int valuesWritten);, so it probably got fixed before release.

[bartonjs]

Video

Looks good as proposed.

Marking the non-out variant with EditorBrowsable.Never, but we decided to defer that to a later discussion (or never, as the case may be). It may be more related to adding a non-try int WriteBytes(destination) than this overload.

namespace System
{
    public partial struct Guid
    {
        public bool TryWriteBytes(Span<byte> destination, out int bytesWritten);
    }
}