Skip to content

Please update Binaryen in emsdk #114723

Open
@Bonicgamer

Description

@Bonicgamer

Is your feature request related to a problem? Please describe.

I've been trying to work on compiling Opus and SpeexDSP to Wasm to be able to use it with a project called VoiceCraft, but it won't work because wasm-opt is getting passed bulk-memory-opt and call-indirect-overlong flags which support wasn't added for until v121 (The version that comes with the Emscripten SDK is v117). This is preventing me from continuing the work I've started here.

Describe the solution you'd like

Please update the Binaryen tools used in the .NET emsdk to v121 or higher.

Additional context

To reproduce this you can simply compile Opus by cloning the repo and doing:

./autogen.sh
mkdir build && cd build
emcmake cmake .. -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release -DOPUS_BUILD_PROGRAMS=OFF -DOPUS_STACK_PROTECTOR_HELP_STR=OFF -DOPUS_DISABLE_INTRINSICS_HELP_STR=ON -DCMAKE_C_FLAGS=-m32 -DCMAKE_CXX_FLAGS=-m32
emmake make # and then this should produce a file called "libopus.a"

Then include it with in your .csproj file with <NativeFileReference Include="opus.a" />

If you need and extra help to reproduce this let me know!

P.S. Idk if this is the right place to ask this.

Metadata

Metadata

Assignees

Labels

arch-wasmWebAssembly architecturearea-WorkloadsWorkloads like wasm-toolsos-browserBrowser variant of arch-wasm

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions