Skip to content

Question about Sse2 Intrinsics Tests And use of private static #113231

Open
@kkukshtel-unity

Description

@kkukshtel-unity

Description

For the following files:

src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToInt32WithTruncation.Int32.cs
src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToInt64WithTruncation.Vector128Double.cs
src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToUInt64.Vector128UInt64.cs
src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToVector128Double.Double.cs

The tests on these are marked privateand are not tagged with the [Fact]attribute from XUnit.

Normally for Intrinsic tests, the convention seems to be that the main test entry method is public and marked [Fact]. I can't find any other reference to these specific test methods elsewhere in the codebase, so I'm wondering if they are meant to be ignored and are just kept around for legacy reasons. Or said differently, if we're trying to replicate your own testing infrastructure, what is the proper way to handle these files?

cc @tannergooding

Reproduction Steps

N/A

Expected behavior

N/A

Actual behavior

N/A

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions