Reduce number of exceptions in HttpClientFactory

[Ilchert]

Description

After updating to .net 8 from .net 7 we faced with many of first chance exceptions in our services with following stack trace.

System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'IServiceProvider'.
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.ThrowHelper.ThrowObjectDisposedException()
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
   at Microsoft.Extensions.Http.DefaultHttpClientFactory.<.ctor>b__14_1()
   at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
--- End of stack trace from previous location ---
   at System.Lazy`1.CreateValue()
   at Microsoft.Extensions.Http.DefaultHttpClientFactory.Log.TryGetLogger(Lazy`1 loggerLazy, ILogger& logger)

Reproduction Steps

AppDomain.CurrentDomain.FirstChanceException += CurrentDomain_FirstChanceException;

void CurrentDomain_FirstChanceException(object? sender, System.Runtime.ExceptionServices.FirstChanceExceptionEventArgs e)
{
    Console.WriteLine(e.Exception.ToString()); // this will print ObjectDisposedException
}

var sc = new ServiceCollection();
sc.AddHttpClient("client").SetHandlerLifetime(TimeSpan.FromSeconds(3));
var sp = sc.BuildServiceProvider();

var f = sp.GetRequiredService<IHttpClientFactory>();
using var httpClient = f.CreateClient("client");

sp.Dispose();

await Task.Delay(10000);

Expected behavior

Should not throw unnecessary exceptions.

Actual behavior

Throw ObjectDisposedException.

Regression?

Yes, works fine in .net 7

Known Workarounds

No response

Configuration

.NET 8 SDK 8.0.303

Other information

It is related to this empty catch block and captured by our logging system.

runtime/src/libraries/Microsoft.Extensions.Http/src/DefaultHttpClientFactory.cs

Lines 382 to 386 in ed13b35

	try
	{
	logger = loggerLazy.Value;
	}
	catch { } // not throwing in logs

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.