Skip to content

Add bucket size hints to histograms #104137

@JamesNK

Description

@JamesNK

Histogram bucket annotations were added with #63650. But they need to used with histograms that are published.

All dotnet/runtime histograms use seconds so they should have an annotation to provide good bucket boundaries.

CreateHistogram<double>() usages: https://github.com/search?q=repo%3Adotnet%2Fruntime%20CreateHistogram&type=code. Looks like they're currently all networking related.

dotnet/aspnetcore doing the same thing: dotnet/aspnetcore#56500

This is easy to do and should be done in .NET 9. It allows opentelemetry-dotnet to remove a hack to infer the bucket sizes. They can replace that code with code that looks at the attached bucket sizes.

Metadata

Metadata

Assignees

Labels

area-System.Net.HttpenhancementProduct code improvement that does NOT require public API changes/additionsin-prThere is an active PR which will close this issue when it is merged

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions