[Perf] Windows/x64: 3 Regressions on 6/3/2024 10:30:18 PM

[performanceautofiler]

Run Information

Name	Value
Architecture	x64
OS	Windows 10.0.22631
Queue	ViperWindows
Baseline	c6bfb06e23458e583c46cb2162c827acc8dd2f35
Compare	9a3d45a66d96dd73b360471e0de8f0c5fb7c89c0
Diff	Diff
Configs	CompilationMode:tiered, RunKind:micro

Regressions in System.IO.Tests.StringReaderReadLineTests

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio
ReadLineAsync - Duration of single invocation 📝 - Benchmark Source ADX - Test Multi Config Graph	53.30 μs	65.99 μs	1.24	0.42	False
ReadLine - Duration of single invocation 📝 - Benchmark Source ADX - Test Multi Config Graph	9.93 μs	10.73 μs	1.08	0.09	False
ReadLine - Duration of single invocation 📝 - Benchmark Source ADX - Test Multi Config Graph	65.66 μs	72.42 μs	1.10	0.00	False

Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.IO.Tests.StringReaderReadLineTests*'

System.IO.Tests.StringReaderReadLineTests.ReadLineAsync(LineLengthRange: [ 1, 8])

ETL Files

Histogram

JIT Disasms

System.IO.Tests.StringReaderReadLineTests.ReadLine(LineLengthRange: [ 9, 32])

ETL Files

Histogram

JIT Disasms

System.IO.Tests.StringReaderReadLineTests.ReadLine(LineLengthRange: [ 1, 1])

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

[LoopedBard3]

Commit range: 2a80808...1e0c243

Slightly suspect this PR: #101020

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

[LoopedBard3]

Other potentially related regressions:
Windows x64: dotnet/perf-autofiling-issues#36066, dotnet/perf-autofiling-issues#36074

Linux x64: dotnet/perf-autofiling-issues#36053

[adamsitnik]

Moving to area-System.Runtime since it seems to be related to the recent StringBuilder changes

[stephentoub]

Moving to area-System.Runtime since it seems to be related to the recent StringBuilder changes

@adamsitnik, which changes? I'm missing it in the diff.