[API Proposal]: Trim method for string

[Mr0N]

Background and motivation

I propose to add the following overloads for the Trim, TrimEnd, and TrimStart methods. The ones that currently work only with the char type."
https://learn.microsoft.com/en/dotnet/api/system.string.trim?view=net-8.0
https://learn.microsoft.com/en-us/dotnet/api/system.string.trimend?view=net-8.0
https://learn.microsoft.com/en-us/dotnet/api/system.string.trimstart?view=net-8.0

API Proposal

class Example
{
    public string Trim(string trimText)
        => throw new NotSupportedException();
    public string TrimStart(string trimText)
        => throw new NotSupportedException();
    public string TrimEnd(string trimText)
        => throw new NotSupportedException();
}

API Usage

string text = "__32__".Trim("__");//Result:32
string textBegin = "__32__".TrimStart("__");//Result:32__
string textEnd = "__32__".TrimEnd("__");//Result:__32

Alternative Designs

No response

Risks

No response

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

[KeterSCP]

.NET 9 already added overloads that accept ReadOnlySpan<char>:

• string.Trim
• string.TrimStart
• string.TrimEnd

[huoyaoyuan]

.NET 9 already added overloads that accept ReadOnlySpan<char>

No, this is the one that's easily confused. Here ReadOnlySpan<char> means a collection of chars, not a string.

If we add a method to trim for strings, it should better be a different name.

[Mr0N]

.NET 9 already added overloads that accept ReadOnlySpan<char>

No, this is the one that's easily confused. Here ReadOnlySpan<char> means a collection of chars, not a string.

If we add a method to trim for strings, it should better be a different name.

.NET 9 already added overloads that accept ReadOnlySpan<char>

No, this is the one that's easily confused. Here ReadOnlySpan<char> means a collection of chars, not a string.

If we add a method to trim for strings, it should better be a different name.

A string in other quotes, how can they be confused?

""//string
''//char

[KeterSCP]

easily confused

It is indeed very confusing. As an API consumer, I would expect that "abHELLOab".Trim("ba") would not change the input string. I suspect that when .NET 9 is released, this new API will cause a lot of false positive bug reports

[Mr0N]

Well, just replace ReadOnlySpan with string and everything will be clear.

[stephentoub]

It is indeed very confusing

cc: @terrajobst, @bartonjs

[Mr0N]

Well, just replace ReadOnlySpan with string and everything will be clear.

Without considering this new attribute, for the reload rating.
Well, it's not great because you need to know the internal implementation of the class to call its methods.