Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 58801184a1
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3429fee9ed
Choose a head ref
  • 7 commits
  • 19 files changed
  • 8 contributors

Commits on Oct 3, 2024

  1. [release/9.0] Update System.Formats.Nrbf ref sources and restore pack… 

    …age description (#108467)

* Restore System.Formats.Nrbf package description alongside package README

* Add missing struct members to ref source

* Update ref to match dotnet msbuild /t:GenerateReferenceAssemblySource

* Remove 'EnableDefaultPackageReadmeFile' since 'true' is the default

---------

Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
    @github-actions @jeffhandley
    github-actions[bot] and jeffhandley authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0277184 View commit details
    Browse the repository at this point in the history

  2. [aot] mono_aot_split_options: reset state after a backslash (#108212) 

    Fixes #108066

Co-authored-by: Aleksey Kliger <alklig@microsoft.com>
Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    @github-actions @lambdageek @jeffschwMSFT
    3 people authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3812e13 View commit details
    Browse the repository at this point in the history

  3. Fix devirtualization across genericness in the hierarchy (#108442) (#… 

    …108470)

This code was trying to answer question: "Was this method overriden by something else in a more derived class"? It was walking the base hierarchy in canonical form, but that was leading to methods not resolving at all. The fix is to walk the non-canonical hierarchy and canonicalize after we resolved everything.

I ran into this in #108379 that unlocked more whole program devirtualization and `StringSearchValuesBase` is in this shape.

Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    @MichalStrehovsky @jeffschwMSFT
    MichalStrehovsky and jeffschwMSFT authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2924cc8 View commit details
    Browse the repository at this point in the history

  4. [cdac][cdac-build-tool] Don't let msbuild rewrite the resource name (#… 

    …108296)

Work around dotnet/msbuild#9152

Possibly fixes #107936

Co-authored-by: Aleksey Kliger <alklig@microsoft.com>
Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    @github-actions @lambdageek @jeffschwMSFT
    3 people authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    728b131 View commit details
    Browse the repository at this point in the history

  5. [release/9.0] Fix InlineArray swift lowering in mono (#108483) 

    * Fix lowering support for inline arrays (#107744)

* [Swift interop] Add inline array struct lowering tests (#107859)

* [swift interop] Add inline array tests

* Rename test suite

---------

Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    @jkurdek @jeffschwMSFT
    jkurdek and jeffschwMSFT authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5f87907 View commit details
    Browse the repository at this point in the history

  6. Backport of Fix statics issue with barriers (#108311) (#108347) 

    * Fix statics issue with barriers

* Add barriers for RiscV and Loongson

Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    @davidwrighton @jeffschwMSFT
    davidwrighton and jeffschwMSFT authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    69db0ee View commit details
    Browse the repository at this point in the history

  7. [release/9.0] Fix wrong Region Info Names (#108524) 

    * Fix wrong RegionInfo Names

* Exclude the test on Windows 8 for the lack of full globalization data

---------

Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
    @github-actions @tarekgh
    github-actions[bot] and tarekgh authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3429fee View commit details
    Browse the repository at this point in the history
Loading