[release/9.0] Fix InlineArray swift lowering in mono#108483
Merged
jeffschwMSFT merged 3 commits intodotnet:release/9.0from Oct 3, 2024
Merged
[release/9.0] Fix InlineArray swift lowering in mono#108483jeffschwMSFT merged 3 commits intodotnet:release/9.0from
InlineArray swift lowering in mono#108483jeffschwMSFT merged 3 commits intodotnet:release/9.0from
Conversation
* [swift interop] Add inline array tests * Rename test suite
jkurdek
requested review from
jeffschwMSFT,
jkoritzinsky,
kotlarmilos and
vitek-karas
Contributor
|
Tagging subscribers to 'os-tvos': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger |
lambdageek
approved these changes
Oct 2, 2024
kotlarmilos
approved these changes
Oct 2, 2024
jeffschwMSFT
approved these changes
Oct 2, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 9 GA
vitek-karas
approved these changes
Oct 2, 2024
jeffschwMSFT
added
Servicing-approved
This was referenced Oct 2, 2024
Open
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Runtime is green. extra-platforms failures unrelated. |
This was referenced Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #107744 and #107859 to release/9.0
Customer Impact
In .NET 9 we added swift lowering algorithm to both CoreCLR and Mono backends. This included support for lowering
InlineArray. The scenario lacked appropriate tests, once we started working on projections we found out that the Mono path is completely broken (runtime crash when attempting to pass struct annotated withInlineArray).Regression
Testing
New test suite for
InlineArraylowering. Tests are included in this change.Risk
Low. Only affects swift interop path on mono. Changes are small, easy to reason about and well tested.