Skip to content

Commit e2424d0

Browse files
mmitcheakoeplinger
andauthored
Sign and harden pkgs (#114027)
* Sign and harden pkgs * Fix missing closing quote in MacOSPkg element * Add singlefilehost to MacOS signing list * Add new executables to MacOS signing list * Add 'Mono' to MacOS signing list * Remove inadvertently added lines --------- Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
1 parent a1997d4 commit e2424d0

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

eng/Signing.props

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,12 @@
4343
<FileSignInfo Include="mscordaccore.dll" CertificateName="None" />
4444
<FileSignInfo Include="mscordbi.dll" CertificateName="None" />
4545

46-
<!-- On MacOS, we need to sign a number of our executables with the Mac developer cert with hardening enabled. -->
47-
<FileSignInfo Condition="'$(TargetsOSX)' == 'true'" Include="dotnet;apphost;corerun;createdump" CertificateName="MacDeveloperHarden" />
46+
<!-- On MacOS, we need to sign a number of our executables with the Mac developer cert with hardening enabled.
47+
Avoid doing this on Linux, which has the same executable names -->
48+
<FileSignInfo Condition="'$(TargetsOSX)' == 'true'" Include="dotnet;apphost;corerun;createdump;singlefilehost;crossgen2;ilasm;ilc;ildasm;llc;mono-aot-cross;opt;Mono" CertificateName="MacDeveloperHarden" />
49+
<!-- Additionally, we need to notarize any .pkg files -->
50+
<MacOSPkg Include="$(ArtifactsPackagesDir)**/dotnet-runtime*.pkg" Exclude="$(ArtifactsPackagesDir)**/dotnet-runtime-internal*.pkg" />
51+
<FileSignInfo Include="@(MacOSPkg->'%(Filename)%(Extension)')" CertificateName="MacDeveloperWithNotarization" />
4852

4953
<!-- We don't need to code sign .js files because they are not used in Windows Script Host. -->
5054
<!-- WARNING: Needs to happed outside of any target -->

0 commit comments

Comments
 (0)