Skip to content

Sign and harden pkgs #114027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 2, 2025
Merged

Sign and harden pkgs #114027

merged 7 commits into from
Apr 2, 2025

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Mar 28, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings March 28, 2025 21:58
Copilot
Copilot AI reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • eng/Signing.props: Language not supported

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 28, 2025
@mmitche
Copy link
Member Author

mmitche commented Mar 28, 2025

https://dev.azure.com/dnceng/internal/_build/results?buildId=2674223&view=results

@mmitche mmitche requested a review from jkoritzinsky March 28, 2025 21:58
@mmitche mmitche requested a review from a team March 28, 2025 21:58
jkoritzinsky
jkoritzinsky approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmitche mmitche mentioned this pull request Mar 28, 2025
Closed
@kg kg mentioned this pull request Apr 3, 2025
Closed
This was referenced Mar 29, 2025
Open
Open
Open
Open
Open
Closed
@mmitche
Copy link
Member Author

mmitche commented Mar 31, 2025

@jkoritzinsky Results are as expected for runtime. Signed and notarized outputs!

@build-analysis build-analysis bot mentioned this pull request Apr 1, 2025
Open
3 tasks
@mmitche mmitche mentioned this pull request Apr 1, 2025
Closed
@mmitche
Copy link
Member Author

mmitche commented Apr 1, 2025

Validated with the new file list.

@build-analysis build-analysis bot mentioned this pull request Apr 1, 2025
Open
@mmitche
Copy link
Member Author

mmitche commented Apr 1, 2025

What's the latest process to check in runtime? Does BA need to be green?

@jkoritzinsky
Copy link
Member

/ba-g timeouts are known

@mmitche mmitche merged commit e2424d0 into dotnet:main Apr 2, 2025
146 of 151 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@akoeplinger akoeplinger akoeplinger approved these changes

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@mmitche mmitche

Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmitche @jkoritzinsky @akoeplinger