Ignore SendMessageTimeout failures on Windows Nano Server (#80099)

* Ignore SendMessageTimeout failures on Windows Nano Server * Fix tests Fixes #30566
dotnet · Jan 3, 2023 · 6c2b939 · 6c2b939
1 parent e574fbe
commit 6c2b939
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/System/Environment.Win32.cs b/src/libraries/System.Private.CoreLib/src/System/Environment.Win32.cs
@@ -56,7 +56,9 @@ private static void SetEnvironmentVariableFromRegistry(string variable, string?
                 {
                     IntPtr unused;
                     IntPtr r = Interop.User32.SendMessageTimeout(new IntPtr(Interop.User32.HWND_BROADCAST), Interop.User32.WM_SETTINGCHANGE, IntPtr.Zero, (IntPtr)lParam, 0, 1000, &unused);
-                    Debug.Assert(r != IntPtr.Zero, $"SetEnvironmentVariable failed: {Marshal.GetLastPInvokeError()}");
+
+                    // SendMessageTimeout message is a empty stub on Windows Nano Server that fails with both result and last error 0.
+                    Debug.Assert(r != IntPtr.Zero || Marshal.GetLastPInvokeError() == 0, $"SetEnvironmentVariable failed: {Marshal.GetLastPInvokeError()}");
                 }
             }
         }

diff --git a/src/libraries/System.Runtime.Extensions/tests/System/Environment.GetEnvironmentVariable.cs b/src/libraries/System.Runtime.Extensions/tests/System/Environment.GetEnvironmentVariable.cs
@@ -220,9 +220,9 @@ public void EnumerateEnvironmentVariables(EnvironmentVariableTarget target)
             bool lookForSetValue = (target == EnvironmentVariableTarget.Process)
                 || (PlatformDetection.IsWindows && PlatformDetection.IsPrivilegedProcess);
 
-            // [ActiveIssue("https://github.com/dotnet/runtime/issues/30566")]
-            if (PlatformDetection.IsWindowsNanoServer && target == EnvironmentVariableTarget.User)
+            if (target == EnvironmentVariableTarget.User && PlatformDetection.IsWindowsNanoServer)
             {
+                // Windows Nano Server does not have full per-user registry hives
                 lookForSetValue = false;
             }
 

diff --git a/src/libraries/System.Runtime.Extensions/tests/System/Environment.SetEnvironmentVariable.cs b/src/libraries/System.Runtime.Extensions/tests/System/Environment.SetEnvironmentVariable.cs
@@ -16,9 +16,9 @@ public class SetEnvironmentVariable
 
         internal static bool IsSupportedTarget(EnvironmentVariableTarget target)
         {
-            // [ActiveIssue("https://github.com/dotnet/runtime/issues/30566")]
             if (target == EnvironmentVariableTarget.User && PlatformDetection.IsWindowsNanoServer)
             {
+                // Windows Nano Server does not have full per-user registry hives
                 return false;
             }
 

diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj
@@ -425,10 +425,6 @@
     <!-- https://github.com/dotnet/runtime/issues/72908 -->
     <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Reflection.MetadataLoadContext\tests\System.Reflection.MetadataLoadContext.Tests.csproj" />
 
-    <!-- https://github.com/dotnet/runtime/issues/30566 -->
-    <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Extensions\tests\System.Runtime.Extensions.Tests.csproj"
-                       Condition="'$(RuntimeConfiguration)' == 'checked' and '$(TargetOS)' == 'windows'" />
-
     <!-- Test needs to copy .so file: https://github.com/dotnet/runtime/issues/72987 -->
     <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.Ports\tests\System.IO.Ports.Tests.csproj"
                       Condition="'$(TargetOS)' != 'windows'" />