Skip to content

Commit

Permalink
JIT: Set false target for BBJ_COND predecessor to first cold block (#…
Browse files Browse the repository at this point in the history
…96412)

Fixes #96391. In #96265, I neglected to set the false target for BBJ_COND blocks preceding the first cold block when inserting a fixup block between the two
  • Loading branch information
amanasifkhalid authored Jan 3, 2024
1 parent 4e0ffca commit 653739c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/coreclr/jit/flowgraph.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3225,6 +3225,7 @@ PhaseStatus Compiler::fgDetermineFirstColdBlock()
BasicBlock* transitionBlock =
fgNewBBafter(BBJ_ALWAYS, prevToFirstColdBlock, true, firstColdBlock);
transitionBlock->inheritWeight(firstColdBlock);
prevToFirstColdBlock->SetFalseTarget(transitionBlock);

// Update the predecessor list for firstColdBlock
fgReplacePred(firstColdBlock, prevToFirstColdBlock, transitionBlock);
Expand Down

0 comments on commit 653739c

Please sign in to comment.