Skip to content

Commit

Permalink
Run illink before ApiCompat (#66706)
Browse files Browse the repository at this point in the history
* Run illink before ApiCompat and GenAPI

As observed in #66634 (comment), illink currently runs after APICompat. This happens because nuget imports the ApiCompat targets earlier than the illink.targets is imported.

* Update illink.targets

* Use ApiCompatDependsOn
  • Loading branch information
ViktorHofer authored Apr 26, 2022
1 parent b42adad commit 6387a2d
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions eng/illink.targets
Original file line number Diff line number Diff line change
@@ -1,17 +1,10 @@
<Project>
<PropertyGroup>
<IsTrimmable Condition="'$(IsTrimmable)' == ''">true</IsTrimmable>
<PrepareResourcesDependsOn>
_EmbedILLinkXmls;
$(PrepareResourcesDependsOn)
</PrepareResourcesDependsOn>
</PropertyGroup>

<PropertyGroup>
<TargetsTriggeredByCompilation Condition="'$(DesignTimeBuild)' != 'true'">
$(TargetsTriggeredByCompilation);
ILLinkTrimAssembly
</TargetsTriggeredByCompilation>
<PrepareResourcesDependsOn>_EmbedILLinkXmls;$(PrepareResourcesDependsOn)</PrepareResourcesDependsOn>
<TargetsTriggeredByCompilation Condition="'$(DesignTimeBuild)' != 'true'">$(TargetsTriggeredByCompilation);ILLinkTrimAssembly</TargetsTriggeredByCompilation>
<!-- ApiCompat should perform compatibility checks on the trimmed assemblies. -->
<ApiCompatDependsOn>$(ApiCompatDependsOn);ILLinkTrimAssembly</ApiCompatDependsOn>
</PropertyGroup>

<!-- Inputs and outputs of ILLinkTrimAssembly -->
Expand Down

0 comments on commit 6387a2d

Please sign in to comment.