Skip to content

Commit 5832fed

Browse files
authored
[wasm][debugger] Fix test failing on firefox (#89607)
Do not send `SetJustMyCode` on firefox, as it does not support this setting. On-behalf-of: @thaystg
1 parent ae38a3f commit 5832fed

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1581,15 +1581,14 @@ public async Task<JObject> WaitForEventAsync(string eventName)
15811581
}
15821582
}
15831583

1584-
internal async Task SetJustMyCode(bool enabled)
1584+
internal virtual async Task SetJustMyCode(bool enabled)
15851585
{
15861586
var req = JObject.FromObject(new { JustMyCodeStepping = enabled });
15871587
var res = await cli.SendCommand("DotnetDebugger.setDebuggerProperty", req, token);
15881588
Assert.True(res.IsOk);
15891589
Assert.Equal(res.Value["justMyCodeEnabled"], enabled);
15901590
}
15911591

1592-
15931592
internal async Task SetSymbolOptions(JObject param)
15941593
{
15951594
var res = await cli.SendCommand("DotnetDebugger.setSymbolOptions", param, token);

src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestFirefox.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,8 @@ private JObject ConvertFirefoxToDefaultFormat(JArray frames, JObject wait_res)
182182
});
183183
}
184184

185+
internal override Task SetJustMyCode(bool enabled) => Task.CompletedTask;
186+
185187
internal override async Task<JObject> SendCommandAndCheck(JObject args, string method, string script_loc, int line, int column, string function_name,
186188
Func<JObject, Task> wait_for_event_fn = null, Func<JToken, Task> locals_fn = null, string waitForEvent = Inspector.PAUSE)
187189
{

0 commit comments

Comments
 (0)