Remove unnecessary closures from Logging{Scope}HttpMessageHandler.Sen…

…dCoreAsync (#89160) * Avoid unnecessary closure in LoggingHttpMessageHandler.SendCoreAsync * Remove unnecessary closure in LoggingScopeHttpMessageHandler.SendCoreAsync
dotnet · Jul 19, 2023 · 54c0756 · 54c0756
1 parent 0321755
commit 54c0756
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/libraries/Microsoft.Extensions.Http/src/Logging/LoggingHttpMessageHandler.cs b/src/libraries/Microsoft.Extensions.Http/src/Logging/LoggingHttpMessageHandler.cs
@@ -50,9 +50,9 @@ public LoggingHttpMessageHandler(ILogger logger, HttpClientFactoryOptions option
         private Task<HttpResponseMessage> SendCoreAsync(HttpRequestMessage request, bool useAsync, CancellationToken cancellationToken)
         {
             ThrowHelper.ThrowIfNull(request);
-            return Core(request, cancellationToken);
+            return Core(request, useAsync, cancellationToken);
 
-            async Task<HttpResponseMessage> Core(HttpRequestMessage request, CancellationToken cancellationToken)
+            async Task<HttpResponseMessage> Core(HttpRequestMessage request, bool useAsync, CancellationToken cancellationToken)
             {
                 Func<string, bool> shouldRedactHeaderValue = _options?.ShouldRedactHeaderValue ?? _shouldNotRedactHeaderValue;
 

diff --git a/src/libraries/Microsoft.Extensions.Http/src/Logging/LoggingScopeHttpMessageHandler.cs b/src/libraries/Microsoft.Extensions.Http/src/Logging/LoggingScopeHttpMessageHandler.cs
@@ -50,9 +50,9 @@ public LoggingScopeHttpMessageHandler(ILogger logger, HttpClientFactoryOptions o
         private Task<HttpResponseMessage> SendCoreAsync(HttpRequestMessage request, bool useAsync, CancellationToken cancellationToken)
         {
             ThrowHelper.ThrowIfNull(request);
-            return Core(request, cancellationToken);
+            return Core(request, useAsync, cancellationToken);
 
-            async Task<HttpResponseMessage> Core(HttpRequestMessage request, CancellationToken cancellationToken)
+            async Task<HttpResponseMessage> Core(HttpRequestMessage request, bool useAsync, CancellationToken cancellationToken)
             {
                 var stopwatch = ValueStopwatch.StartNew();