fix(analyzers): skip RCS1231 for ref struct parameters - #1807
Merged
Conversation
Making ref struct parameters `in` can break returning them by value. Fixes #1725. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
josefpihrt
commented
Aug 11, 2026
josefpihrt
left a comment
josefpihrt
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review notes for skipping RCS1231 on ref struct parameters. Clean fix for #1725.
This was referenced Aug 16, 2026
Closed
This was referenced Aug 24, 2026
Open
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make parameter ref read-only) forref structparameters; suggestingincan break returning the parameter by value.Fixes #1725
Test plan
dotnet test src/Tests/Analyzers.Tests --filter FullyQualifiedName~RCS1231Made with Cursor