Change Span of PutFullAccessorOnOwnLine to be correct #1661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes the application of the code fix
josefpihrt
requested changes
Jul 26, 2025
|
And sorry for late review 😊 |
I've updated the tests to be correct, as there's no new functionality I'm not sure what kind of test I would have to add, but I did see that I forgot to update the tests. But that's done now. |
|
@dotnet-policy-service agree |
josefpihrt
approved these changes
Aug 24, 2025
|
@niekschoemaker Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The span used to be empty causing the warning to only appear when building, and not in the IDE (at least for Rider) unless something like Error lens is active.
I changed it to match the span it expects for the code fix, and also removed the break because both accessors can be wrong, and this way it correctly marks both of them as being on the wrong line. Otherwise applying the code fix would suddenly cause a new warning for the other accessor.