MSBuild location not found with .NET 9 and must be specified explicitly

[fgimian]

Hey there, hope you're doing well. I've been trying out the Roslynator CLI recently but am being forced to explicitly pass my MSBuild path.

Here are my dotnet global tools:

Package Id                             Version      Commands
--------------------------------------------------------------------
csharpier                              0.30.1       dotnet-csharpier
csharprepl                             0.6.7        csharprepl
dotnet-outdated-tool                   4.6.4        dotnet-outdated
dotnet-reportgenerator-globaltool      5.4.1        reportgenerator
roslynator.dotnet.cli                  0.9.3        roslynator

And here are my .NET SDK paths along with MSBuild locations:

C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin\MSBuild.exe
C:\Program Files\dotnet\sdk\9.0.101\MSBuild.dll

And here's what I see when running Roslynator:

~\source\oriel on  main
🕙 [ 05:23:52 PM ] ❯ roslynator.exe analyze -v diag
Roslynator Version: 0.9.3.0
Roslynator Target Framework: .NET Core
Roslyn Version: 4.11.0.0
MSBuild location not found. Use option '-m, --msbuild-path' to specify MSBuild location

It works as expected when explicitly specifying the MSBuild directory path like so:

roslynator.exe analyze -m 'C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin'

or

roslynator.exe analyze -m 'C:\Program Files\dotnet\sdk\9.0.101'

This all works perfectly when having .NET SDK 8 installed so I'm assuming .NET 9 is not yet supported for the CLI out of the box?

Thanks heaps
Fotis

[fgimian]

Furthermore, despite my project being marked as a .NET 9 project, the Roslynator CLI dislikes this call to string.Join.

namespace ConsoleApp1;

internal class Program
{
    static void Main()
    {
        var s = string.Join(',', [1, 2, 3, 4]);
        Console.WriteLine(s);
    }
}

Here's the output:

Loading project 'C:\Users\Fots\source\ConsoleApp1\ConsoleApp1.csproj'...
Analyze 'ConsoleApp1'
  Program.cs(7,24): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(char, params ReadOnlySpan<object?>)' and 'string.Join<T>(char, IEnumerable<T>)'
Analyzed project 'C:\Users\Fots\source\ConsoleApp1\ConsoleApp1.csproj' (in 2.4 s)

1 CS0121

1 diagnostic found

This is indeed the case for .NET 8 in Visual Studio too if <TargetFramework>net8.0</TargetFramework>:

However, upgrading the project to resolves the issue:

Even when explicitly specifying the MSBuild path with .NET SDK 9, the error still appears:

~\source\ConsoleApp1 via .NET v9.0.101 🎯 net9.0 took 3s
🕙 [ 05:37:24 PM ] ❯ roslynator.exe analyze -m 'C:\Program Files\dotnet\sdk\9.0.101'
Loading project 'C:\Users\Fots\source\ConsoleApp1\ConsoleApp1.csproj'...
Analyze 'ConsoleApp1'
  Program.cs(7,24): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(char, params ReadOnlySpan<object?>)' and 'string.Join<T>(char, IEnumerable<T>)'
Analyzed project 'C:\Users\Fots\source\ConsoleApp1\ConsoleApp1.csproj' (in 2.5 s)

1 CS0121

1 diagnostic found

Thanks heaps!
Fotis

[josefpihrt]

Yes, .NET 9 is not supported yet. There is open PR for it: #1579

[fgimian]

Yes, .NET 9 is not supported yet. There is open PR for it: #1579

Thanks so much for the reply, I'll go ahead and close this issue and continue to track this via the PR. 😄

Cheers
Fotis

[fgimian]

Hey there @josefpihrt, thanks so much for releasing a new version with .NET 9 support.

The latest version does run correctly but I'm still seeing some strange results:

~\source\oriel on  main took 17s
🕙 [ 03:07:26 PM ] ❯ roslynator.exe analyze
Loading solution 'C:\Users\Fots\source\oriel\Oriel.sln'...
Analyze solution 'C:\Users\Fots\source\oriel\Oriel.sln'
Analyze 'Oriel' 1/2
  Internal\FileVersionsRetriever.cs(13,42): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(char, params ReadOnlySpan<object?>)' and 'string.Join<T>(char, IEnumerable<T>)'
  Internal\FileVersionsRetriever.cs(22,45): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(char, params ReadOnlySpan<object?>)' and 'string.Join<T>(char, IEnumerable<T>)'
Analyze 'Oriel.Tests' 2/2
Analyzed solution 'C:\Users\Fots\source\oriel\Oriel.sln' (in 16.8 s)

2 CS0121

2 diagnostics found

Meanwhile there are no errors in VS Code or Visual Studio and the solution builds just fine:

~\source\oriel on  main took 18s
🕙 [ 03:07:52 PM ] ❯ dotnet build
Restore complete (0.5s)
  Oriel succeeded (11.2s) → src\Oriel\bin\Debug\net9.0-windows10.0.26100.0\Oriel.dll
  Oriel.Tests succeeded (1.4s) → src\Oriel.Tests\bin\Debug\net9.0-windows10.0.26100.0\Oriel.Tests.dll

Build succeeded in 13.3s

I've tried fully cleaning the project and building again, but the same issue persists.

Here's the related code:

using System.Diagnostics;
using System.Text.RegularExpressions;

namespace Oriel.Internal;

internal static partial class FileVersionsRetriever
{
    public static FileVersions GetFileVersions(string path)
    {
        var versionInfo = FileVersionInfo.GetVersionInfo(path);

        return new FileVersions(
            fileVersionFromParts: string.Join(
                '.',
                [
                    versionInfo.FileMajorPart,
                    versionInfo.FileMinorPart,
                    versionInfo.FileBuildPart,
                    versionInfo.FilePrivatePart,
                ]
            ),
            productVersionFromParts: string.Join(
                '.',
                [
                    versionInfo.ProductMajorPart,
                    versionInfo.ProductMinorPart,
                    versionInfo.ProductBuildPart,
                    versionInfo.ProductPrivatePart,
                ]
            ),
            fileVersion: versionInfo.FileVersion is not null
                ? SanitiseVersion(versionInfo.FileVersion)
                : null,
            productVersion: versionInfo.ProductVersion is not null
                ? SanitiseVersion(versionInfo.ProductVersion)
                : null
        );
    }

    internal static SoftwareVersion SanitiseVersion(SoftwareVersion version)
    {
        var match = VersionRegex().Match(version);
        return match.Success
            ? string.Join(
                '.',
                match
                    .Groups.Values.Skip(1)
                    .Select(gv => gv.Value)
                    .Where(v => !string.IsNullOrEmpty(v))
            )
            : version;
    }

    [GeneratedRegex(@"^(\d+),\s*(\d+)(?:,\s*(\d+))?(?:,\s*(\d+))?$")]
    private static partial Regex VersionRegex();
}

If I switch to declaring an array, I end up with IDE0300 whereby the suggestion takes me back to a collection expression.

Cheers
Fotis

[josefpihrt]

@fgimian Could you please create a new issue for it?

[fgimian]

@fgimian Could you please create a new issue for it?

Sure, no worries. Thanks!