Better handle dismissed rename tracking sessions #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New PR because I cannot reopen #770. We want to eventually the implementation from reanalyzing diagnostics to implementing IDiagnosticUpdateSource, but that depends on #885 being completed. For the current milestone, let's proceed with this interim solution as it fixes certain cases and the rest of the time it avoids the confusion of committing the lightbulb item and having nothing happen. |
| @@ -1,13 +1,13 @@ | |||
| // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | |||
|
|
|||
| using System; | |||
There was a problem hiding this comment.
Other files in this PR keep the System directives at the top.
There was a problem hiding this comment.
Fixed. Thanks Brett.
|
👍 |
Fixes dotnet#540 "Stale rename entries in the lightbulb menu" Prior to this change, dismissed rename tracking sessions continued to provide codefixes which would silently fail when invoked, without completing the rename operation. With this change, we now do the following when rename tracking is manually dismissed: - Trigger the diagnostic service to reanalyze the document, thus removing the rename tracking diagnostic. - Stop providing a codefix when requested - Show a dialog if a cached codefix is invoked explaining that the rename was not performed. Here are the there user scenarios: 1. The user dismisses rename tracking - The lightbulb will continue to show in the margin, regardless of whether any codefix/refactoring is actually still available. 2. The user expands the lightbulb without it ever having been expanded before. - In this case, we are queried for fixes and will not return any, so either the lightbulb will disappear or it will contain other relevant codefixes/refactorings at that position, excluding rename. 3. The user expands the lightbulb after it was previously expanded. - Our fix was already cached, so we can only give a reasonable message when it is invoked. Once dotnet#885 is fixed, we can instead implement IDiagnosticUpdateSource and avoid forcing diagnostic reanalysis.
dpoeschl
force-pushed
the
RenameTrackingEscapeCrash
branch
from
a03d9d5 to
499a46f
Compare
|
@balajikris - can you take a look? |
|
👍 |
dpoeschl
added a commit
that referenced
this pull request
Mar 4, 2015
Better handle dismissed rename tracking sessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #540 "Stale rename entries in the lightbulb menu"
Prior to this change, dismissed rename tracking sessions continued to
provide codefixes which would silently fail when invoked, without
completing the rename operation.
With this change, we now do the following when rename tracking is
manually dismissed:
removing the rename tracking diagnostic.
rename was not performed.
Here are the there user scenarios:
whether any codefix/refactoring is actually still available.
before.
either the lightbulb will disappear or it will contain other relevant
codefixes/refactorings at that position, excluding rename.
when it is invoked.
Once #885 is fixed, we can instead implement IDiagnosticUpdateSource and
avoid forcing diagnostic reanalysis.