Move some more rules to System.Runtime.Analyzers #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are all about assembly level attributes and dont' have fixers because we don't have lightbulbs in the error list yet (for issues that don't have a location).
|
@mavasani @heejaechang @tmeschter @shyamnamboodiripad @JohnHamby - can a couple of you take a look? |
|
Ping |
|
👍 |
srivatsn
added a commit
that referenced
this pull request
Mar 4, 2015
Move some more rules to System.Runtime.Analyzers
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CA2231 - this is very similar to CA1036. So refactored them a bit to share code. Simplified the fixer with SyntaxGenerator.
CA1014, CA1016, CA1017 are all analyzers for assembly attributes and they don't have fixers because we don't have fixes for project-level issues.