Small allocation optimization to SyntaxFacts.HasYieldOperations#82491
Closed
ToddGrun wants to merge 1 commit intodotnet:mainfrom
Closed
Small allocation optimization to SyntaxFacts.HasYieldOperations#82491ToddGrun wants to merge 1 commit intodotnet:mainfrom
ToddGrun wants to merge 1 commit intodotnet:mainfrom
Conversation
LightBulbInvocationTestForCsharp speedometer test shows about 2.2 MB (0.2%) of allocations in VS during it's scenarios as pooled array allocations / resizes in this method. The method being tested is fairly large, and ends up causing the ArrayBuilder instances to exceed the pooled maximum size. Instead of adding items to the array to be tested in this method, instead add enumerators to the array and walk those.
Contributor
Author
|
/pr-val |
Contributor
|
View PR Validation Run triggered by @ToddGrun Parameters
|
Contributor
Author
|
Bummer. Speedometer results came back actually worse than the original. Looked at the exact form of the document being edited by the speedometer and tested against it locally (200 methods in the file). What ends up happening a highly parallel call into HasYieldOperations, such that the Free calls end up trampling over each other in ObjectPool.(Free/FreeSlow). Lock free pooling ends up causing object loss with this high of contention, and because I've increased the size of each entry in the array, the total allocated loss is greater with this change. Going to abandon, as I can't think of a nice way around this. :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In draft mode until speedometer results come back.
LightBulbInvocationTestForCsharp speedometer test shows about 2.2 MB (0.2%) of allocations in VS during it's scenarios as pooled array allocations / resizes in this method. The method being tested is fairly large, and ends up causing the ArrayBuilder instances to exceed the pooled maximum size. Instead of adding items to the array to be tested in this method, instead add enumerators to the array and walk those.