Fix InvalidCastException in ConvertForToForEach with tuples #81531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 81530
Problem
VS crashes with
InvalidCastExceptionwhen "Convert to foreach" refactoring analyzesa for loop where the iteration variable is used inside a tuple:
Cause
TupleExpressionSyntaxcontainsArgumentSyntaxchildren but is NOT aBaseArgumentListSyntaxThe code assumed argument's parent is always a valid argument list.
Fix
Check if it's a valid element access or invocation BEFORE calling
GetArgumentsOfArgumentListTesting
Added
TestNotWithIterationVariableInTupleExpression