Improve location of error diagnostic when encountering errant operator token #81295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@roslyn-compiler ptal |
CyrusNajmabadi
commented
Nov 17, 2025
| var result = await service.AnalyzeChangeAsync( | ||
| document, [new TextChange(new TextSpan(listIndex, 1), """ | ||
| <<<<<<< | ||
| <<<<<<< goo |
Member
Author
There was a problem hiding this comment.
this test wanted to make merge-conflict-markers. but by leaving off the trailing text just ended up with lots of operator tokens, all of which had error locations get updated by the parsing change.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31774
Fixes #58298