Fix cycle in partial event interface implementation #80994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjonescz
changed the title
jjonescz
commented
Nov 4, 2025
|
|
||
| private EmitData GetEmitData() => _emitData ?? throw new InvalidOperationException("Must call Emit first"); | ||
|
|
||
| internal PortableExecutableReference GetImageReference( |
Member
Author
There was a problem hiding this comment.
📝 inspired by GetCompilation(...).EmitToImageReference - there was no equivalent for CompileAndVerify afaict
Member
Author
|
@RikkiGibson @dotnet/roslyn-compiler for a second review, thanks |
1 similar comment
Member
Author
|
@RikkiGibson @dotnet/roslyn-compiler for a second review, thanks |
333fred
approved these changes
Nov 10, 2025
| Assert.Null(e2.PartialDefinitionPart); | ||
| } | ||
|
|
||
| [Fact] |
Member
Author
There was a problem hiding this comment.
I think these are not directly related to the issue, they are just a byproduct of the fix. (One is actually just testing a pre-existing behavior.) The related tests (InterfaceImplementation*) have WorkItem attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80986.
Also ensures both partial event parts have consistent
IsWindowsRuntimeEvent(this discrepancy appeared during testing).