Skip to content

Clean up a Razor external access service #80830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidwengier merged 2 commits into from
Oct 21, 2025
Merged

Clean up a Razor external access service #80830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b8ccb4
Clean up a Razor external access service
davidwengier Oct 21, 2025
44cf1a5
Revert https://github.com/dotnet/roslyn/pull/80815 and bring those ch…
davidwengier Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/Tools/ExternalAccess/Razor/Features/Cohost/Handlers/SemanticTokensRange.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,6 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.Razor.Cohost.Handlers
{
internal static class SemanticTokensRange
{
public static void RegisterRefresh(RazorCohostRequestContext requestContext)
{
var refreshQueue = requestContext.GetRequiredService<SemanticTokensRefreshQueue>();
refreshQueue.AllowRazorRefresh = true;
}

public static Task TryEnqueueRefreshComputationAsync(RazorCohostRequestContext requestContext, Project project, CancellationToken cancellationToken)
{
var refreshQueue = requestContext.GetRequiredService<SemanticTokensRefreshQueue>();
return refreshQueue.TryEnqueueRefreshComputationAsync(project, cancellationToken);
}

public static Task<int[]> GetSemanticTokensAsync(
Document document,
ImmutableArray<LinePositionSpan> spans,
Expand Down
8 changes: 2 additions & 6 deletions src/Tools/ExternalAccess/Razor/Features/Cohost/RazorSemanticTokensRefreshQueueWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public ILspService CreateILspService(LspServices lspServices, WellKnownLspServer
return new RazorSemanticTokensRefreshQueueWrapper(semanticTokensRefreshQueue);
}

internal class RazorSemanticTokensRefreshQueueWrapper(SemanticTokensRefreshQueue semanticTokensRefreshQueue) : IRazorSemanticTokensRefreshQueue, IDisposable
internal class RazorSemanticTokensRefreshQueueWrapper(SemanticTokensRefreshQueue semanticTokensRefreshQueue) : IRazorSemanticTokensRefreshQueue
{
public void Initialize(string clientCapabilitiesString)
{
Expand All @@ -36,14 +36,10 @@ public void Initialize(string clientCapabilitiesString)
// Initialize method in the queue itself is resilient to being called twice, so it doesn't actually do
// any harm.
semanticTokensRefreshQueue.Initialize(clientCapabilities);
semanticTokensRefreshQueue.AllowRazorRefresh = true;
}

public Task TryEnqueueRefreshComputationAsync(Project project, CancellationToken cancellationToken)
=> semanticTokensRefreshQueue.TryEnqueueRefreshComputationAsync(project, cancellationToken);

public void Dispose()
{
semanticTokensRefreshQueue.Dispose();
}
}
}
Loading