Add friendlier error message on an explicit implementation when the return type is wrong #80376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
Community
Member
|
@stbau04 in general, please avoid force pushing to PRs in roslyn. It breaks our ability to incrementally review changes. We will squash your changes at the end anyway. |
Contributor
Author
|
Noted, i'll not do that again |
added 10 commits
September 20, 2025 11:45
added 3 commits
September 20, 2025 21:29
333fred
reviewed
Sep 22, 2025
src/Compilers/CSharp/Portable/Symbols/Source/ExplicitInterfaceHelpers.cs
Outdated
Show resolved
Hide resolved
…Helpers.cs Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
# Conflicts: # src/Compilers/CSharp/Portable/Errors/ErrorCode.cs # src/Compilers/CSharp/Portable/Errors/ErrorFacts.cs
333fred
approved these changes
Sep 23, 2025
Member
333fred
left a comment
333fred
left a comment
There was a problem hiding this comment.
@dotnet/roslyn-compiler for a second review
Member
|
Taking a look today, sorry I missed the notification. |
RikkiGibson
approved these changes
Sep 26, 2025
| // UnavailableClass[] CSharpErrors.InterfaceMethods.ReturnType2() { return null; } | ||
| Diagnostic(ErrorCode.ERR_SingleTypeNameNotFound, "UnavailableClass").WithArguments("UnavailableClass").WithLocation(5, 5), | ||
| // (5,54): error CS0539: 'C.ReturnType2()' in explicit interface declaration is not a member of interface | ||
| // (5,54): error CS9334: 'C.ReturnType2()': return type must be 'UnavailableClass[]' to match implemented member 'InterfaceMethods.ReturnType2()' |
Member
There was a problem hiding this comment.
If you wish, you could consider opening a follow up PR after this one, to avoid reporting a "bad implementation" error, when the implementation signature already has errors, which I believe is called out in the "CONSIDER" comment in the implementation.
Member
|
Thanks for the contribution! |
This was referenced Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60742
New pr instead of #80267 as Github apparently behaves different in comparison to Bitbucket when a branch with pr is deleted and pushed again