Skip to content

Don't show Razor diagnostics in Full Solution Analysis #80296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2025
Merged

Don't show Razor diagnostics in Full Solution Analysis #80296

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70ae1f8
Don't show Razor diagnostics in Full Solution Analysis
davidwengier Sep 16, 2025
ec1633e
Update src/LanguageServer/Protocol/Handler/Diagnostics/DiagnosticSour…
davidwengier Sep 16, 2025
2cd1d11
Update src/LanguageServer/Protocol/Handler/Diagnostics/DiagnosticSour…
davidwengier Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...otocol/Handler/Diagnostics/DiagnosticSources/AbstractWorkspaceDocumentDiagnosticSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using System.Threading;
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.Host;
using Roslyn.Utilities;

namespace Microsoft.CodeAnalysis.LanguageServer.Handler.Diagnostics;
Expand Down Expand Up @@ -38,6 +39,14 @@ public override async Task<ImmutableArray<DiagnosticData>> GetDiagnosticsAsync(
{
if (Document is SourceGeneratedDocument sourceGeneratedDocument)
{
if (sourceGeneratedDocument.IsRazorSourceGeneratedDocument())
{
// Razor has not ever participated in diagnostics for closed files, so we filter then out when doing FSA. They will handle
// their own open file diagnostics. Additionally, if we reported them here, they would should up as coming from a `.g.cs` file
// which is not what the user wants anyway.
return [];
}

// Unfortunately GetDiagnosticsForIdsAsync returns nothing for source generated documents.
var service = this.Solution.Services.GetRequiredService<IDiagnosticAnalyzerService>();
var documentDiagnostics = await service.GetDiagnosticsForSpanAsync(
Expand Down
Loading