Disallow TypeSpec after CLASS and VALUETYPE in signatures #8027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nguerrera @AlekseyTs @dotnet/roslyn-compiler |
|
|
||
| File.WriteAllBytes( | ||
| Args[0], | ||
| BitConverter.ToString(File.ReadAllBytes(Args[0])) |
There was a problem hiding this comment.
Nit against my own repro code here. I meant to use the file local instead of repeating Args[0] twice.
|
Some small comments, but LGTM. |
| <Content Include="MetadataTests\Invalid\Signatures\munge.csx" /> | ||
| <Content Include="MetadataTests\Invalid\Signatures\SignatureCycle2.il" /> | ||
| <Content Include="MetadataTests\Invalid\Signatures\TypeSpecInWrongPlace.il" /> | ||
| <EmbeddedResource Include="MetadataTests\Invalid\Signatures\SignatureCycle2.exe" /> |
There was a problem hiding this comment.
Can we please stop checking in .exe files? Unless it is truly tiny.
There was a problem hiding this comment.
It is tiny (2KB). This is the current pattern we use in compilers, I don't see what's wrong with it. The file will never change.
There was a problem hiding this comment.
BTW, as soon as we'll have a metadata writer it will be much easier to write these tests without checking in binaries. But for now this is what we do.
|
LGTM |
|
@dotnet/roslyn-compiler Can I get one more review please? |
|
|
||
| [WorkItem(7971, "https://github.com/dotnet/roslyn/issues/7971")] | ||
| [Fact(Skip = "7971")] | ||
| public void MemberSignature_CycleTrhuTypeSpecInCustomModifiers() |
|
LGTM |
tmat
added a commit
that referenced
this pull request
Jan 21, 2016
Disallow TypeSpec after CLASS and VALUETYPE in signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #7970. This change makes the compiler behave the same as native csc.
Also adds a test for issue #7971.