Skip to content

Report error when MetadataUpdateDeletedAttribute is applied manually #80125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2025
Merged

Report error when MetadataUpdateDeletedAttribute is applied manually #80125

merged 4 commits into from
Sep 16, 2025

Conversation

@tmat
Copy link
Member

@tmat tmat commented Sep 3, 2025 •
edited
Loading

Relates to API proposal dotnet/runtime#118903
Relates to EnC feature dotnet/runtime#75154

Implements #80106

@tmat tmat marked this pull request as ready for review September 4, 2025 01:22
@tmat tmat requested a review from a team as a code owner September 4, 2025 01:22
@tmat
Copy link
Member Author

tmat commented Sep 4, 2025 •
edited
Loading

@dotnet/roslyn-compiler @phil-allen-msft ptal

jcouv
jcouv reviewed Sep 4, 2025
View reviewed changes
jcouv
jcouv approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (commit 3)

@jcouv jcouv self-assigned this Sep 4, 2025
@steveisok steveisok mentioned this pull request Sep 11, 2025
Merged
AlekseyTs
AlekseyTs reviewed Sep 15, 2025
View reviewed changes
@AlekseyTs
Copy link
Contributor

Doe with review pass (commit 3)

AlekseyTs
AlekseyTs approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 4)

@tmat tmat merged commit a4d213a into dotnet:main Sep 16, 2025
24 checks passed
@tmat tmat deleted the ReportMUA branch September 16, 2025 21:09
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 16, 2025
@akhera99 akhera99 modified the milestones: Next, 18.0 P1, 18.0 P2 Sep 22, 2025
@jeffhandley jeffhandley mentioned this pull request Oct 9, 2025
Merged
4 tasks
This was referenced Oct 27, 2025
Open
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels

Area-Compilers

Projects

None yet

Milestone

18.0 P2

Development

Successfully merging this pull request may close these issues.

4 participants

@tmat @AlekseyTs @jcouv @akhera99