Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Collections.Immutable;
using System.Diagnostics;
using System.Linq;
using System.Runtime.CompilerServices;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.PooledObjects;
Expand Down Expand Up @@ -68,14 +69,35 @@ private static int GetPriority(DiagnosticAnalyzer state)
}
}

private static readonly ConditionalWeakTable<Project, StrongBox<ImmutableArray<DiagnosticAnalyzer>>> s_projectToAnalyzers = new();

/// <summary>
/// Return <see cref="DiagnosticAnalyzer"/>s for the given <see cref="Project"/>.
/// </summary>
internal ImmutableArray<DiagnosticAnalyzer> GetProjectAnalyzers(Project project)
public ImmutableArray<DiagnosticAnalyzer> GetProjectAnalyzers(Project project)
{
var hostAnalyzerInfo = GetOrCreateHostAnalyzerInfo(project);
var projectAnalyzerInfo = GetOrCreateProjectAnalyzerInfo(project);
return hostAnalyzerInfo.OrderedAllAnalyzers.AddRange(projectAnalyzerInfo.Analyzers);
if (!s_projectToAnalyzers.TryGetValue(project, out var lazyAnalyzers))
{
lazyAnalyzers = new(ComputeProjectAnalyzers());
#if NET
s_projectToAnalyzers.TryAdd(project, lazyAnalyzers);
#else
lock (s_projectToAnalyzers)
{
if (!s_projectToAnalyzers.TryGetValue(project, out var existing))
s_projectToAnalyzers.Add(project, lazyAnalyzers);
}
#endif
}

return lazyAnalyzers.Value;

ImmutableArray<DiagnosticAnalyzer> ComputeProjectAnalyzers()
{
var hostAnalyzerInfo = GetOrCreateHostAnalyzerInfo(project);
var projectAnalyzerInfo = GetOrCreateProjectAnalyzerInfo(project);
return hostAnalyzerInfo.OrderedAllAnalyzers.AddRange(projectAnalyzerInfo.Analyzers);
}
}

private HostAnalyzerInfo GetOrCreateHostAnalyzerInfo(Project project)
Expand Down
6 changes: 5 additions & 1 deletion src/Workspaces/Core/Portable/Diagnostics/Extensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,10 @@ public static ImmutableArray<DiagnosticAnalyzer> FilterAnalyzers(
analyzerMap[analyzerId] = analyzer;
}

return [.. analyzerMap.Values];
var result = new FixedSizeArrayBuilder<DiagnosticAnalyzer>(analyzerMap.Count);
foreach (var (_, analyzer) in analyzerMap)
result.Add(analyzer);

return result.MoveToImmutable();
}
}
Loading